archived/coc-tsserver
1
0
Fork 0
Code Issues Pull requests Activity

fix validate settings not respected

Browse source 
Closes #238
This commit is contained in:
Qiming Zhao 2020-12-09 15:21:17 +08:00
parent cca85a2724
commit a31d8acf66
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/server/features/bufferSyncSupport.ts
View file

@ -480,7 +480,10 @@ export default class BufferSyncSupport {
} }
public getErr(resources: Uri[]): any { public getErr(resources: Uri[]): any {
const handledResources = resources.filter(resource => this.handles(resource.toString())) const handledResources = resources.filter(resource => {
let syncedBuffer = this.syncedBuffers.get(resource.toString())
return syncedBuffer && this.shouldValidate(syncedBuffer)
})
if (!handledResources.length) { if (!handledResources.length) {
return return
} }
@ -525,15 +528,20 @@ export default class BufferSyncSupport {
this.pendingGetErr.cancel() this.pendingGetErr.cancel()
for (const uri of this.pendingGetErr.uris) { for (const uri of this.pendingGetErr.uris) {
let resource = uri.toString() let resource = uri.toString()
if (this.syncedBuffers.get(resource)) { let syncedBuffer = this.syncedBuffers.get(resource)
if (syncedBuffer && this.shouldValidate(syncedBuffer)) {
orderedFileSet.set(resource, undefined) orderedFileSet.set(resource, undefined)
} else {
orderedFileSet.delete(resource)
} }
} }
this.pendingGetErr = undefined this.pendingGetErr = undefined
} }
// Add all open TS buffers to the geterr request. They might be visible // Add all open TS buffers to the geterr request. They might be visible
for (const buffer of this.syncedBuffers.values) { for (const buffer of this.syncedBuffers.values) {
orderedFileSet.set(buffer.resource, undefined) if (this.shouldValidate(buffer)) {
orderedFileSet.set(buffer.resource, undefined)
}
} }
if (orderedFileSet.size) { if (orderedFileSet.size) {
let uris = Array.from(orderedFileSet.uris).map(uri => Uri.parse(uri)) let uris = Array.from(orderedFileSet.uris).map(uri => Uri.parse(uri))
@ -554,7 +562,7 @@ export default class BufferSyncSupport {
this._validateTypeScript = tsConfig.get<boolean>('validate.enable', true) this._validateTypeScript = tsConfig.get<boolean>('validate.enable', true)
} }
private shouldValidate(buffer: SyncedBuffer) { private shouldValidate(buffer: SyncedBuffer): boolean {
switch (buffer.kind) { switch (buffer.kind) {
case BufferKind.JavaScript: case BufferKind.JavaScript:
return this._validateJavaScript return this._validateJavaScript