naskya/firefish
1
0
Fork 1
mirror of https://example.com synced 2024-11-24 03:56:38 +09:00
Code Issues Activity

Resolve #7208 (#7226)

Browse source 
add decrement replies count on delete note and a test for that
This commit is contained in:
Ehsan Javadynia 2022-03-22 14:48:33 +01:00 committed by GitHub
parent ba9563b983
commit 08bace6c7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/backend/src/services/note/delete.ts
View file

@ -29,6 +29,10 @@ export default async function(user: User, note: Note, quiet = false) {
Notes.decrement({ id: note.renoteId }, 'score', 1);
}
if (note.replyId) {
await Notes.decrement({ id: note.replyId }, 'repliesCount', 1);
}
if (!quiet) {
publishNoteStream(note.id, 'deleted', {
deletedAt: deletedAt,

32
packages/backend/test/note.ts
View file

@ -333,4 +333,36 @@ describe('Note', () => {
assert.strictEqual(res.status, 400);
}));
});
describe('notes/delete', () => {
it('delete a reply', async(async () => {
const mainNoteRes = await request('/notes/create', {
text: 'main post',
}, alice);
const replyOneRes = await request('/notes/create', {
text: 'reply one',
replyId: mainNoteRes.body.createdNote.id
}, alice);
const replyTwoRes = await request('/notes/create', {
text: 'reply two',
replyId: mainNoteRes.body.createdNote.id
}, alice);
const deleteOneRes = await request('/notes/delete', {
noteId: replyOneRes.body.createdNote.id,
}, alice);
assert.strictEqual(deleteOneRes.status, 204);
let mainNote = await Notes.findOne({id: mainNoteRes.body.createdNote.id});
assert.strictEqual(mainNote.repliesCount, 1);
const deleteTwoRes = await request('/notes/delete', {
noteId: replyTwoRes.body.createdNote.id,
}, alice);
assert.strictEqual(deleteTwoRes.status, 204);
mainNote = await Notes.findOne({id: mainNoteRes.body.createdNote.id});
assert.strictEqual(mainNote.repliesCount, 0);
}));
});
});