naskya/napi-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #942 from napi-rs/disable-js-without-platform

Browse source 
fix(cli): disable js binding generation if no --platform flag
This commit is contained in:
LongYinan 2021-12-18 15:59:29 +08:00 committed by GitHub
commit 049b8799c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/src/build.ts
View file

@ -76,7 +76,7 @@ export class BuildCommand extends Command {
jsBinding = Option.String('--js', 'index.js', { jsBinding = Option.String('--js', 'index.js', {
description: `Path to the JS binding file, pass ${chalk.underline( description: `Path to the JS binding file, pass ${chalk.underline(
chalk.yellow('false'), chalk.yellow('false'),
)} to disable it`, )} to disable it. Only affect if ${chalk.green('--target')} specified.`,
}) })
cargoCwd?: string = Option.String('--cargo-cwd', { cargoCwd?: string = Option.String('--cargo-cwd', {
@ -299,7 +299,9 @@ export class BuildCommand extends Command {
} }
} }
const jsBindingFilePath = const jsBindingFilePath =
this.jsBinding && this.jsBinding !== 'false' this.jsBinding &&
this.jsBinding !== 'false' &&
this.appendPlatformToFilename
? join(process.cwd(), this.jsBinding) ? join(process.cwd(), this.jsBinding)
: null : null
await writeJsBinding(binaryName, packageName, jsBindingFilePath, idents) await writeJsBinding(binaryName, packageName, jsBindingFilePath, idents)