Merge pull request #38 from Brooooooklyn/node14

ci: add node14 to test matrix

.github/workflows/linux.yaml

@@ -7,7 +7,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ['10', '12', '13']
+        node: ['10', '12', '13', '14']
         version:
           - stable
           - nightly

.github/workflows/macos.yaml

@@ -7,7 +7,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ['10', '12', '13']
+        node: ['10', '12', '13', '14']
         version:
           - stable
           - nightly

.github/workflows/windows.yaml

@@ -7,7 +7,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: ['10', '12', '13']
+        node: ['10', '12', '13', '14']
         version:
           - stable
           - nightly

README.md

@@ -16,9 +16,9 @@
 
 ## NodeJS
 
-| Node10    | Node 12   | Node13    |
+| Node10 | Node 12 | Node13 | Node14 |
-| --------- | --------- | --------- |
+| ------ | ------- | ------ | ------ |
-| ✓         | ✓         | ✓         |
+| ✓      | ✓       | ✓      | ✓      |
 
 A minimal library for building compiled Node add-ons in Rust.
 

test_module/src/lib.rs

@@ -5,7 +5,7 @@ extern crate napi_rs_derive;
 
 extern crate futures;
 
-use napi::{Any, Env, Error, Object, Result, Status, Value, CallContext};
+use napi::{Any, CallContext, Env, Error, Object, Result, Status, Value};
 
 register_module!(test_module, init);
 
@@ -13,21 +13,13 @@ fn init<'env>(
   env: &'env Env,
   exports: &'env mut Value<'env, Object>,
 ) -> Result<Option<Value<'env, Object>>> {
-  exports.set_named_property(
+  exports.set_named_property("testSpawn", env.create_function("testSpawn", test_spawn)?)?;
-    "testSpawn",
+  exports.set_named_property("testThrow", env.create_function("testThrow", test_throw)?)?;
-    env.create_function("testSpawn", test_spawn)?,
-  )?;
-  exports.set_named_property(
-    "testThrow",
-    env.create_function("testThrow", test_throw)?,
-  )?;
   Ok(None)
 }
 
 #[js_function]
-fn test_spawn<'a>(
+fn test_spawn<'a>(ctx: CallContext<'a>) -> Result<Value<'a, Object>> {
-  ctx: CallContext<'a>
-) -> Result<Value<'a, Object>> {
   use futures::executor::ThreadPool;
   use futures::StreamExt;
   let env = ctx.env;
@@ -37,7 +29,7 @@ fn test_spawn<'a>(
   let (tx, rx) = futures::channel::mpsc::unbounded::<i32>();
   let fut_values = async move {
     let fut_tx_result = async move {
-      (0..100).for_each(|v| {
+      (0..20).for_each(|v| {
         tx.unbounded_send(v).expect("Failed to send");
       })
     };
@@ -60,8 +52,6 @@ fn test_spawn<'a>(
 }
 
 #[js_function]
-fn test_throw<'a>(
+fn test_throw<'a>(_ctx: CallContext<'a>) -> Result<Value<'a, Any>> {
-  _ctx: CallContext<'a>,
-) -> Result<Value<'a, Any>> {
   Err(Error::new(Status::GenericFailure))
 }