From fe8f061f1f77826e5119e935cc9d0c98997f8630 Mon Sep 17 00:00:00 2001
From: LongYinan <lynweklm@gmail.com>
Date: Thu, 11 Nov 2021 16:59:24 +0800
Subject: [PATCH] fix(napi-derive-backend): typegen issue when arg is mut

---
 crates/backend/src/typegen/fn.rs            |   6 ++++++
 examples/napi/__test__/typegen.spec.ts.md   |   2 +-
 examples/napi/__test__/typegen.spec.ts.snap | Bin 956 -> 952 bytes
 examples/napi/index.d.ts                    |   2 +-
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/crates/backend/src/typegen/fn.rs b/crates/backend/src/typegen/fn.rs
index 4c93b3e8..48a779e5 100644
--- a/crates/backend/src/typegen/fn.rs
+++ b/crates/backend/src/typegen/fn.rs
@@ -1,5 +1,6 @@
 use convert_case::{Case, Casing};
 use quote::ToTokens;
+use syn::Pat;
 
 use super::{ty_to_ts_type, ToTypeDef, TypeDef};
 use crate::{CallbackArg, FnKind, NapiFn};
@@ -49,6 +50,11 @@ impl NapiFn {
           if path.ty.to_token_stream().to_string() == "Env" {
             return None;
           }
+          let mut path = path.clone();
+          // remove mutability from PatIdent
+          if let Pat::Ident(i) = path.pat.as_mut() {
+            i.mutability = None;
+          }
           let mut arg = path.pat.to_token_stream().to_string().to_case(Case::Camel);
           arg.push_str(": ");
           arg.push_str(&ty_to_ts_type(&path.ty, false));
diff --git a/examples/napi/__test__/typegen.spec.ts.md b/examples/napi/__test__/typegen.spec.ts.md
index 66ac07d0..a5582548 100644
--- a/examples/napi/__test__/typegen.spec.ts.md
+++ b/examples/napi/__test__/typegen.spec.ts.md
@@ -43,7 +43,7 @@ Generated by [AVA](https://avajs.dev).
     export function readPackageJson(): PackageJson␊
     export function getPackageJsonName(packageJson: PackageJson): string␊
     export function contains(source: string, target: string): boolean␊
-    export function concatStr(mutS: string): string␊
+    export function concatStr(s: string): string␊
     export function concatUtf16(s: string): string␊
     export function concatLatin1(s: string): string␊
     export function withoutAbortController(a: number, b: number): Promise<number>␊
diff --git a/examples/napi/__test__/typegen.spec.ts.snap b/examples/napi/__test__/typegen.spec.ts.snap
index 17956eb968ca791f2c5388439da84a91c119bda9..3b1d6568b853ac5ec58e601cf870f81ddf4a146a 100644
GIT binary patch
literal 952
zcmV;p14sNpRzV<BZeeh9Xm4~Nb}|YA0D<T?kc0>xvYXc`nG`oz2Oo<F00000000Ax
zRn3muHW1b}XbbGEhoILv(tr;8mrW`p3wZy~ZCY=TO%U`*Nn@F@L>eTuUSqqj(N}06
zqPL<z?>+YwddxXP%JRyVRoe%7D1P&OoZ-v}f*{xlp8WdlKY#!C^B=!Gd;aO)zyADv
zCvd-~yFu_I_}be$Uk2ZN@zpNgO_a7UEM;Pal8~YOpmb_jFM__-eD=~<Eo64G4ml``
z22hqojJgdpW#NIeZ&tA6TUjk9jXb>+Irhy=CTzm(D1z!F<nu<WLKu8`S`LTn6uEQy
zsm!f-H&u-5td?o`cAYjBnUJ=hri@2$DzYnSLx^j$R~s$AgidU++GN|ou8xoX2TA!o
zo2D$`c^>m*9DxgDZ;=Ifbpp3aq(tEUIuqC?xX@Z@_ytOt;!sFTL!gcQnwfTFndch?
zP}mXb8}D<i2R@xl$Vq9JnC5Bkyk=W!dEu#Q=Y`J-OUDTgJ4DHdmCBLJM|rwg)I**i
zT*n{beiz`jE%VSJbhJ^3EaGiNi?oE-LZ)yJ=PH9&uouD^w`A;xa9$>3vJT*334c}^
zt6bw;xYa#eORVrz(hg3>NTYjq7{aA0HCaa?+=x3ejzhQ**~lrp2w@<+?|0;a(vj@J
znixsuow_<aU>Gfnci)~JX*Kob#JZ}a;FIf#v)C=qqsNT-5?fif`?%`D3go+RQ#}nu
ztRzno!Q^IeE{vu7dW|!~RQxdldSGHVPQI##$<sw$`7|o)4fPt&@CQRkS7DMDSl5gz
zIMjwn8gEjZAhn`Q1k!wbiwVu&xi)pCoSoF^anRfIZPD#3b|ay2I(PcUa@_!GY!4_5
zn!}6rlJBBf+qqKGav=>fRHDfu5g}NbIcOV0ecnUs7!q!2&M?zJcgqp@y&di!Zx8>G
zTOs$i!B1%rsM7XhdV5BZX_e<RxH@Wd)2GI<Z9^4;5t(%D<Iy*Mu?0WnxB5c*uZ*{9
zOp<eBpf5$ib6=&dHk8a~Fs3;b`DsOODL<5nGO^U*j~n4qP4@_AETu5<0XaYe>zc`{
z5Q@&@Jz1|&{ic4o$~he=UWjFEB||(kM!isPe$<EMz)o{M#)H%ExuLo3<6Ai-&e#}d
z(Ht1lx)&{bbx;zr;#=8vSBQ7E)@mkhB|+!ha+cDgQEqc@0v1RWmNueZ)p5@cM03d<
a`E1>YX^0J4nT=W$B=H#y1h26*3IG6npU(*Z

literal 956
zcmV;t14H~lRzV<BZeeh9Xm4~Nb}|YA0DRhL%zN@>**3r^d@1xT4<CyN00000000Ax
zRn3muHW1b}D2nc_r}Q{S8qi_?vPp$x0q-BWP3sM^34$IeX)H6ANQ0!-Yi##5`U>qs
z^i~w;z309{k2z;ZSzg()YWpA$#c#fkGn^Sg5Cl8HlV6|y^Y?#0|MA<i=b!%l>(AeJ
z0{8oNHwc~tUwM1y%ix<YzTU;ViP9E^rA(|)5;C+OluixnMbOup&t4j<h0IRYAqQpA
z0Lrq6QMZAnEIg3*%?g%$E34(Ck*Aj;$G(}#giW{|MNplDeBNkP2!k(A%i(aHB6m(d
zmAMt~riyW$)iMp=uG7XM6Vmq6l<^2oMRp}^2yt!pYNO?s(1|Tpn`}GS)$!5)ASu6R
z)08DV&tsm9BXEK2EwTWwPT*FFlnC5kX9C*<7g{R~zd$Kd914kP2(+<ZGt-VN^L(QK
z3Oho5<9)96z^9W5IVtTD(>(2+*KA8IFFaN4yzp6J={Uh*hbS4bQaN(@C{H(wddL%m
z>-Zzw?*iPmWga?&jy4LBMZB$Ok(TgU$Q173TxIYI_Ch%0mW=%n&dX#>)&V>$;m=BA
zm1~>}x4MUGi4~qo+QG>fX>{)nL%39>ChI7K8*xX*aR?V88##p+Aq<4~{f=BvI+8tD
z6C=sIQ&)!v45MZ7?%T5?t){-5SXY%4d~!W;7Q5wn^q4VUVk_%*A6H#ifqWNks;8ld
zmE=hxnA{A`g|T#BuW@FWia$m`4@~UF$yfC-dAg`8pGIZ9p<d$|{$L2{DopYM>zZ)|
zhuRQH<4uYaq*j!PK$?$lF`@Z8*QU;tvy(bK4tjgOExLWhZX`5L=T6^Pt{Xs&?E!^B
zb9k{{@?A7*J6B3tE~H_GN;Fv{A_Pk_2W?}h&wFScL&7c18CI0`rs2@7Nci`5xPQ#d
zw(uXh6>@(Y{FG*aDs4Zew`UZbR(VddtD{UeeQg}uHdG-PkxAD<9)05%TkungtB<7r
z(0HrHBsn(*`cf1;_l4@pL&<ywV;WVFA6WF3@<W*@6H870xDhUub&qhyQVJ6vkOMTZ
zuAjULq3Ar`ll2-6VCt8voYRrwg;>T`GQ>lZ)C=|IM}1fh>@??NJUIQH8yej{zLi7b
zjE!*?&4Dqkd(pC22PGjZzLjlvg?MLct!Cm@5_HZjXDK}z<u>;wV1ZO&X(Q@Y9rye|
eG?(0w&(=+uhS;E$*{DT95}yG8=tze+3IG6F@WxsI

diff --git a/examples/napi/index.d.ts b/examples/napi/index.d.ts
index 66f9791c..a1e3c170 100644
--- a/examples/napi/index.d.ts
+++ b/examples/napi/index.d.ts
@@ -33,7 +33,7 @@ interface PackageJson {
 export function readPackageJson(): PackageJson
 export function getPackageJsonName(packageJson: PackageJson): string
 export function contains(source: string, target: string): boolean
-export function concatStr(mutS: string): string
+export function concatStr(s: string): string
 export function concatUtf16(s: string): string
 export function concatLatin1(s: string): string
 export function withoutAbortController(a: number, b: number): Promise<number>