diff --git a/.github/workflows/asan.yml b/.github/workflows/asan.yml new file mode 100644 index 00000000..41920480 --- /dev/null +++ b/.github/workflows/asan.yml @@ -0,0 +1,83 @@ +name: Address Sanitizer + +env: + DEBUG: 'napi:*' + +on: + push: + branches: + - main + pull_request: + +jobs: + build_and_test: + strategy: + fail-fast: false + matrix: + node: ['17'] + os: [ubuntu-latest] + + name: nightly - ${{ matrix.os }} - node@${{ matrix.node }} + runs-on: ${{ matrix.os }} + + steps: + - uses: actions/checkout@v2 + + - name: Setup node + uses: actions/setup-node@v2 + with: + node-version: ${{ matrix.node }} + check-latest: true + cache: 'yarn' + + - name: Install + uses: actions-rs/toolchain@v1 + with: + toolchain: nightly + profile: minimal + components: rust-src + override: true + + - name: Generate Cargo.lock + uses: actions-rs/cargo@v1 + with: + command: generate-lockfile + + - name: Cache cargo registry + uses: actions/cache@v2 + with: + path: ~/.cargo/registry + key: nightly-${{ matrix.os }}-node@${{ matrix.node }}-cargo-registry-trimmed-${{ hashFiles('**/Cargo.lock') }} + + - name: Cache cargo index + uses: actions/cache@v2 + with: + path: ~/.cargo/git + key: nightly-${{ matrix.os }}gnu-node@${{ matrix.node }}-cargo-index-trimmed-${{ hashFiles('**/Cargo.lock') }} + + - name: Cache NPM dependencies + uses: actions/cache@v2 + with: + path: node_modules + key: npm-cache-${{ matrix.os }}-node@${{ matrix.node }}-${{ hashFiles('yarn.lock') }} + + - name: 'Install dependencies' + run: yarn install --frozen-lockfile --ignore-platform --registry https://registry.npmjs.org --network-timeout 300000 + + - name: 'Build TypeScript' + run: yarn build + + - name: Unit tests with address sanitizer + run: | + yarn build:test:asan + LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/9/libasan.so yarn test + env: + RUST_TARGET: x86_64-unknown-linux-gnu + RUST_BACKTRACE: 1 + RUSTFLAGS: -Z sanitizer=address + ASAN_OPTIONS: detect_leaks=0 + + - name: Clear the cargo caches + run: | + cargo install cargo-cache --no-default-features --features ci-autoclean + cargo-cache diff --git a/crates/napi/src/bindgen_runtime/module_register.rs b/crates/napi/src/bindgen_runtime/module_register.rs index 94a2903f..847e6376 100644 --- a/crates/napi/src/bindgen_runtime/module_register.rs +++ b/crates/napi/src/bindgen_runtime/module_register.rs @@ -334,7 +334,7 @@ pub(crate) unsafe extern "C" fn noop( sys::napi_throw_error( env, ptr::null_mut(), - CStr::from_bytes_with_nul_unchecked(b"Class contains no `constructor`, can not new it!") + CStr::from_bytes_with_nul_unchecked(b"Class contains no `constructor`, can not new it!\0") .as_ptr(), ); } diff --git a/package.json b/package.json index 289f1af7..a982893b 100644 --- a/package.json +++ b/package.json @@ -20,6 +20,7 @@ "build:bench": "yarn --cwd ./bench build", "build:memory": "yarn --cwd ./memory-testing build", "build:test": "yarn --cwd ./examples/napi-compat-mode build && yarn --cwd ./examples/napi build", + "build:test:asan": "yarn --cwd ./examples/napi-compat-mode build --cargo-flags='-Zbuild-std' && yarn --cwd ./examples/napi build --cargo-flags='-Zbuild-std'", "build:test:aarch64": "yarn --cwd ./examples/napi-compat-mode build-aarch64 && yarn --cwd ./examples/napi build-aarch64", "build:test:android": "yarn --cwd ./examples/napi-compat-mode build --target aarch64-linux-android && yarn --cwd ./examples/napi build --target aarch64-linux-android", "build:test:android:armv7": "yarn --cwd ./examples/napi-compat-mode build --target armv7-linux-androideabi && yarn --cwd ./examples/napi build --target armv7-linux-androideabi",