naskya/napi-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(napi): create_bigint_from_*128 returned incorrect word_count (#2024)

Browse source 
The value of `word_count` was inconsistent between the node side and rust side when calling `create_bigint_from_i128`/`create_bigint_from_u128`.
This commit is contained in:
翠 / green 2024-04-08 10:43:23 +09:00 committed by GitHub
parent c87944c7f4
commit 71a528535a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/napi/src/env.rs
View file

@ -123,7 +123,7 @@ impl Env {
check_status!(unsafe { check_status!(unsafe {
sys::napi_create_bigint_words(self.0, sign_bit, 2, words, &mut raw_value) sys::napi_create_bigint_words(self.0, sign_bit, 2, words, &mut raw_value)
})?; })?;
Ok(JsBigInt::from_raw_unchecked(self.0, raw_value, 1)) Ok(JsBigInt::from_raw_unchecked(self.0, raw_value, 2))
} }
#[cfg(feature = "napi6")] #[cfg(feature = "napi6")]
@ -131,7 +131,7 @@ impl Env {
let mut raw_value = ptr::null_mut(); let mut raw_value = ptr::null_mut();
let words = &value as *const u128 as *const u64; let words = &value as *const u128 as *const u64;
check_status!(unsafe { sys::napi_create_bigint_words(self.0, 0, 2, words, &mut raw_value) })?; check_status!(unsafe { sys::napi_create_bigint_words(self.0, 0, 2, words, &mut raw_value) })?;
Ok(JsBigInt::from_raw_unchecked(self.0, raw_value, 1)) Ok(JsBigInt::from_raw_unchecked(self.0, raw_value, 2))
} }
/// [n_api_napi_create_bigint_words](https://nodejs.org/api/n-api.html#n_api_napi_create_bigint_words) /// [n_api_napi_create_bigint_words](https://nodejs.org/api/n-api.html#n_api_napi_create_bigint_words)