naskya/napi-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(napi): remove useless create_reference in slice => TypedArray impl (#1975)

Browse source
This commit is contained in:
LongYinan 2024-02-25 00:52:30 +08:00 committed by GitHub
parent 2fda360742
commit 71bbe0ef6f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
crates/napi/src/bindgen_runtime/js_values/arraybuffer.rs
View file

@ -466,10 +466,19 @@ macro_rules! impl_from_slice {
let mut data = ptr::null_mut();
let mut array_buffer = ptr::null_mut();
let mut byte_offset = 0;
let mut ref_ = ptr::null_mut();
check_status!(
unsafe { sys::napi_create_reference(env, napi_val, 1, &mut ref_) },
"Failed to create reference from Buffer"
unsafe {
sys::napi_get_typedarray_info(
env,
napi_val,
&mut typed_array_type,
&mut length,
&mut data,
&mut array_buffer,
&mut byte_offset,
)
},
"Get TypedArray info failed"
)?;
check_status!(
unsafe {