Merge pull request #1115 from napi-rs/fix-cargo-name-restrict

fix(cli): should not throw if cargoName is provided but no package.name
This commit is contained in:
LongYinan 2022-04-01 17:19:11 +08:00 committed by GitHub
commit 83712d7312
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 0 deletions

View file

@ -51,6 +51,13 @@ jobs:
env:
RUST_BACKTRACE: 1
- name: Pass -p and --cargo-name to build
run: |
node ./cli/scripts/index.js build -p napi-examples-binary --cargo-name napi-examples-binary
./napi-examples-binary
env:
RUST_BACKTRACE: 1
- name: Clear the cargo caches
run: |
cargo install cargo-cache --no-default-features --features ci-autoclean

View file

@ -204,6 +204,8 @@ export class BuildCommand extends Command {
let cargoPackageName: string
if (tomlContent.package?.name) {
cargoPackageName = tomlContent.package.name
} else if (this.cargoName) {
cargoPackageName = this.cargoName
} else {
throw new TypeError('No package.name field in Cargo.toml')
}