naskya/napi-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(napi): promise leak (#1403)

Browse source 
Co-authored-by: Xiaopeng Li <lixiaopeng.jetspark@bytedance.com>
This commit is contained in:
Xiaopeng Li 2022-12-29 00:15:55 +08:00 committed by GitHub
parent a131c8aa40
commit ce4c28412a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crates/napi/src/tokio_runtime.rs
View file

@ -1,10 +1,9 @@
use std::future::Future; use std::future::Future;
use std::ptr;
use once_cell::sync::Lazy; use once_cell::sync::Lazy;
use tokio::runtime::Runtime; use tokio::runtime::Runtime;
use crate::{check_status, sys, JsDeferred, JsUnknown, NapiValue, Result}; use crate::{sys, JsDeferred, JsUnknown, NapiValue, Result};
pub(crate) static mut RT: Lazy<Option<Runtime>> = Lazy::new(|| { pub(crate) static mut RT: Lazy<Option<Runtime>> = Lazy::new(|| {
let runtime = tokio::runtime::Runtime::new().expect("Create tokio runtime failed"); let runtime = tokio::runtime::Runtime::new().expect("Create tokio runtime failed");
@ -73,11 +72,6 @@ pub fn execute_tokio_future<
fut: Fut, fut: Fut,
resolver: Resolver, resolver: Resolver,
) -> Result<sys::napi_value> { ) -> Result<sys::napi_value> {
let mut promise = ptr::null_mut();
let mut deferred = ptr::null_mut();
check_status!(unsafe { sys::napi_create_promise(env, &mut deferred, &mut promise) })?;
let (deferred, promise) = JsDeferred::new(env)?; let (deferred, promise) = JsDeferred::new(env)?;
spawn(async move { spawn(async move {