fix(cli): disable js binding generation if no --platform flag
This commit is contained in:
parent
45a74856d6
commit
f577512952
1 changed files with 4 additions and 2 deletions
|
@ -76,7 +76,7 @@ export class BuildCommand extends Command {
|
|||
jsBinding = Option.String('--js', 'index.js', {
|
||||
description: `Path to the JS binding file, pass ${chalk.underline(
|
||||
chalk.yellow('false'),
|
||||
)} to disable it`,
|
||||
)} to disable it. Only affect if ${chalk.green('--target')} specified.`,
|
||||
})
|
||||
|
||||
cargoCwd?: string = Option.String('--cargo-cwd', {
|
||||
|
@ -299,7 +299,9 @@ export class BuildCommand extends Command {
|
|||
}
|
||||
}
|
||||
const jsBindingFilePath =
|
||||
this.jsBinding && this.jsBinding !== 'false'
|
||||
this.jsBinding &&
|
||||
this.jsBinding !== 'false' &&
|
||||
this.appendPlatformToFilename
|
||||
? join(process.cwd(), this.jsBinding)
|
||||
: null
|
||||
await writeJsBinding(binaryName, packageName, jsBindingFilePath, idents)
|
||||
|
|
Loading…
Reference in a new issue