From 078d1ed2d08dc140a8f7d783304b16b5bfd0b929 Mon Sep 17 00:00:00 2001
From: LongYinan <lynweklm@gmail.com>
Date: Wed, 4 Nov 2020 15:54:50 +0800
Subject: [PATCH 1/2] chore(napi): simplify module register, support node@10+

---
 napi/src/js_values/object.rs |  1 +
 napi/src/lib.rs              | 87 ++++++++++++++----------------------
 package.json                 |  2 +-
 tsconfig.json                |  2 +-
 4 files changed, 37 insertions(+), 55 deletions(-)

diff --git a/napi/src/js_values/object.rs b/napi/src/js_values/object.rs
index fa197b8b..027d650b 100644
--- a/napi/src/js_values/object.rs
+++ b/napi/src/js_values/object.rs
@@ -1,4 +1,5 @@
 use super::Value;
+#[cfg(napi6)]
 use crate::sys;
 
 #[repr(transparent)]
diff --git a/napi/src/lib.rs b/napi/src/lib.rs
index 8ce80c4e..bc3425ad 100644
--- a/napi/src/lib.rs
+++ b/napi/src/lib.rs
@@ -155,61 +155,42 @@ macro_rules! register_module {
       }
     }
 
-    extern "C" fn register_module() {
-      use std::ffi::CString;
-      use std::io::Write;
-      use std::os::raw::c_char;
-      use std::ptr;
-      use $crate::{sys, Env, JsObject, Module, NapiValue};
+    use std::ffi::CString;
+    use std::io::Write;
+    use std::os::raw::c_char;
+    use std::ptr;
+    use $crate::{sys, Env, JsObject, NapiValue};
 
+    #[cfg(all(feature = "tokio_rt", napi4))]
+    use $crate::shutdown_tokio_rt;
+
+    #[no_mangle]
+    unsafe extern "C" fn napi_register_module_v1(
+      raw_env: sys::napi_env,
+      raw_exports: sys::napi_value,
+    ) -> sys::napi_value {
+      let env = Env::from_raw(raw_env);
+      let mut exports: JsObject = JsObject::from_raw_unchecked(raw_env, raw_exports);
+      let mut cjs_module = Module { env, exports };
+      let result = $init(&mut cjs_module);
       #[cfg(all(feature = "tokio_rt", napi4))]
-      use $crate::shutdown_tokio_rt;
-      static mut MODULE_DESCRIPTOR: Option<sys::napi_module> = None;
-      unsafe {
-        MODULE_DESCRIPTOR = Some(sys::napi_module {
-          nm_version: 1,
-          nm_flags: 0,
-          nm_filename: concat!(file!(), "\0").as_ptr() as *const c_char,
-          nm_register_func: Some(napi_register_module_v1),
-          nm_modname: concat!(stringify!($module_name), "\0").as_ptr() as *const c_char,
-          nm_priv: 0 as *mut _,
-          reserved: [0 as *mut _; 4],
-        });
-
-        sys::napi_module_register(MODULE_DESCRIPTOR.as_mut().unwrap() as *mut sys::napi_module);
-      }
-
-      #[no_mangle]
-      pub unsafe extern "C" fn napi_register_module_v1(
-        raw_env: sys::napi_env,
-        raw_exports: sys::napi_value,
-      ) -> sys::napi_value {
-        let env = Env::from_raw(raw_env);
-        let mut exports: JsObject = JsObject::from_raw_unchecked(raw_env, raw_exports);
-        let mut cjs_module = Module { env, exports };
-        let result = $init(&mut cjs_module);
-
-        #[cfg(all(feature = "tokio_rt", napi4))]
-        let hook_result = check_status(unsafe {
-          sys::napi_add_env_cleanup_hook(raw_env, Some(shutdown_tokio_rt), ptr::null_mut())
-        });
-
-        #[cfg(not(all(feature = "tokio_rt", napi4)))]
-        let hook_result = Ok(());
-
-        match hook_result.and_then(move |_| result) {
-          Ok(_) => cjs_module.exports.raw(),
-          Err(e) => {
-            unsafe {
-              sys::napi_throw_error(
-                raw_env,
-                ptr::null(),
-                CString::from_vec_unchecked(format!("Error initializing module: {}", e).into())
-                  .as_ptr() as *const _,
-              )
-            };
-            ptr::null_mut()
-          }
+      let hook_result = check_status(unsafe {
+        sys::napi_add_env_cleanup_hook(raw_env, Some(shutdown_tokio_rt), ptr::null_mut())
+      });
+      #[cfg(not(all(feature = "tokio_rt", napi4)))]
+      let hook_result = Ok(());
+      match hook_result.and_then(move |_| result) {
+        Ok(_) => cjs_module.exports.raw(),
+        Err(e) => {
+          unsafe {
+            sys::napi_throw_error(
+              raw_env,
+              ptr::null(),
+              CString::from_vec_unchecked(format!("Error initializing module: {}", e).into())
+                .as_ptr() as *const _,
+            )
+          };
+          ptr::null_mut()
         }
       }
     }
diff --git a/package.json b/package.json
index b1c021a1..f14282cf 100644
--- a/package.json
+++ b/package.json
@@ -6,7 +6,7 @@
     "napi": "scripts/index.js"
   },
   "engines": {
-    "node": ">= 10.15"
+    "node": ">= 10"
   },
   "repository": {
     "type": "git",
diff --git a/tsconfig.json b/tsconfig.json
index cd3c23b2..6ba3a548 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -20,7 +20,7 @@
     "suppressExcessPropertyErrors": true,
     "forceConsistentCasingInFileNames": true,
     "preserveSymlinks": true,
-    "target": "ES2018",
+    "target": "ES2015",
     "sourceMap": true,
     "esModuleInterop": true,
     "stripInternal": true,

From 7c996ebaa0bcfcfa8609ec7c01ce39216aaa7ecf Mon Sep 17 00:00:00 2001
From: LongYinan <lynweklm@gmail.com>
Date: Wed, 4 Nov 2020 16:36:01 +0800
Subject: [PATCH 2/2] chore(napi): remove useless From trait

---
 napi/src/js_values/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/napi/src/js_values/mod.rs b/napi/src/js_values/mod.rs
index 008c9919..cc6825ca 100644
--- a/napi/src/js_values/mod.rs
+++ b/napi/src/js_values/mod.rs
@@ -1,4 +1,4 @@
-use std::convert::{From, TryFrom};
+use std::convert::TryFrom;
 use std::ffi::CString;
 use std::ptr;