naskya/napi-rs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(napi): display should be implemented on error generics (#1497)

Browse source
This commit is contained in:
Hana 2023-02-24 19:46:39 +08:00 committed by GitHub
parent 4fc7cb12f4
commit fc101d0d6b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/napi/src/error.rs
View file

@ -47,9 +47,9 @@ impl<S: AsRef<str>> ToNapiValue for Error<S> {
unsafe impl<S> Send for Error<S> where S: Send + AsRef<str> {} unsafe impl<S> Send for Error<S> where S: Send + AsRef<str> {}
unsafe impl<S> Sync for Error<S> where S: Sync + AsRef<str> {} unsafe impl<S> Sync for Error<S> where S: Sync + AsRef<str> {}
impl error::Error for Error {} impl<S: AsRef<str> + std::fmt::Debug> error::Error for Error<S> {}
impl From<std::convert::Infallible> for Error { impl<S: AsRef<str>> From<std::convert::Infallible> for Error<S> {
fn from(_: std::convert::Infallible) -> Self { fn from(_: std::convert::Infallible) -> Self {
unreachable!() unreachable!()
} }
@ -99,7 +99,7 @@ impl From<anyhow::Error> for Error {
} }
} }
impl fmt::Display for Error { impl<S: AsRef<str> + std::fmt::Debug> fmt::Display for Error<S> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
if !self.reason.is_empty() { if !self.reason.is_empty() {
write!(f, "{:?}, {}", self.status, self.reason) write!(f, "{:?}, {}", self.status, self.reason)