LongYinan
3d48d4464b
fix(cli,napi-derive): re-export types from shared crate ( #1531 )
...
* fix(cli,napi-derive): re-export types from shared crate
* chore: publish
- @napi-rs/cli@2.15.1-alpha.0
* Clippy fix
* Fix memory testing
2023-03-21 18:12:52 +08:00
LongYinan
3b831f42f5
Release independent packages
...
napi@2.12.0
napi-derive@2.12.0
2023-03-21 13:39:58 +08:00
Victor Teo
aee742f185
feat(napi): property getter and setter with closure ( #1526 )
...
* getter with closure with segment fault
* fix getter closure pointer
* add setter
* Cleanup API
* Add test for `create_function_from_closure`
* Fix compile error
* Fix flaky test title
---------
Co-authored-by: LongYinan <lynweklm@gmail.com>
2023-03-21 11:22:07 +08:00
LongYinan
550ef7c3cc
feat: export registers in wasm32 target ( #1529 )
2023-03-20 18:42:27 +08:00
LongYinan
5605bdf7fc
fix(napi): ThreadsafeFunctionHandle never being dropped ( #1530 )
2023-03-20 18:01:09 +08:00
Bo
a6e1ff471c
fix(napi): use weak arc for passing thread_finalize_data
( #1525 )
...
* fix(napi): use weak arc for passing thread_finalize_data
* fix: try to fix test of tsfn_return_promise_timeout
2023-03-20 11:56:54 +08:00
LongYinan
347e81b3cc
chore(napi): upgrade bitflags to v2 ( #1518 )
2023-03-16 11:23:03 +08:00
LongYinan
73db80311a
Release independent packages
...
napi@2.11.4
2023-03-14 21:41:01 +08:00
HotQ
0af728a601
fix(napi): prevent access to tsfn-raw after tsfn finalized( #1514 ) ( #1515 )
2023-03-14 21:31:52 +08:00
LongYinan
c1072462a5
Release independent packages
...
napi@2.11.3
napi-derive@2.11.2
2023-03-14 15:37:34 +08:00
Alberto Pose
ffc4980d52
fix(napi): panic when Promise callbacks trigger after Promise is dropped ( #1469 ) ( #1516 )
...
Co-authored-by: Alberto Pose <albepose@amazon.com>
2023-03-14 15:32:17 +08:00
LongYinan
96959e6425
chore(napi): remove thread_local from dependenies ( #1506 )
2023-03-05 19:49:52 +08:00
Markus
86cfbca33e
feat(napi): expose uv_run ( #1499 )
...
Signed-off-by: MarkusJx <28785953+MarkusJx@users.noreply.github.com>
2023-02-27 17:31:03 +08:00
Hana
fc101d0d6b
fix(napi): display should be implemented on error generics ( #1497 )
2023-02-24 19:46:39 +08:00
LongYinan
25cc07b476
Release independent packages
...
napi@2.11.2
napi-derive@2.11.1
2023-02-18 11:35:57 +08:00
liuyi
7281f533bd
fix(cli): always generate typedef file even native code never changes ( #1489 )
2023-02-16 22:24:40 +08:00
Hana
853f52ed1f
fix(napi): error should be send sync conditionally ( #1487 )
2023-02-14 18:58:04 +08:00
LongYinan
ec9349bb3b
Release independent packages
...
napi@2.11.1
2023-02-09 23:22:29 +08:00
LongYinan
8e3eb6204b
fix(napi): support custom status in Error ( #1486 )
2023-02-09 23:18:57 +08:00
LongYinan
8e5ed4c7a0
Release independent packages
...
napi@2.11.0
napi-derive@2.11.0
2023-02-08 22:33:55 +08:00
Hana
90cc0a6abe
feat(napi): convert ToNapiValue tuple to variadic tsfn ( #1475 )
...
* refactor: convert ToNapiValue tuple to variadic tsfn
* chore: resolve conflicts
* fix: typo
* chore: use into instead of to
* chore: syntax compat
2023-02-08 22:30:43 +08:00
m1212e
a7dcf2a838
fix(napi): convert u64 to u32 in serialization ( #1478 )
...
https://github.com/napi-rs/napi-rs/issues/1470
serde_json::Value parses positive integers to u64 types by default. When converting serde_json::Value to a js value, those numbers are converted to BigInts, even if they are within the bounds of the number primitive. The added checks converts an u64 to an u32 if possible to prevent this behavior.
Co-authored-by: m1212e <->
2023-02-08 22:25:03 +08:00
LongYinan
80ec3dd2d9
Release independent packages
...
napi@2.10.17
2023-02-08 17:34:08 +08:00
LongYinan
c34ccc9131
fix(napi): impl Send Sync to External
2023-02-08 17:33:27 +08:00
LongYinan
f24c9e6e83
Release independent packages
...
napi@2.10.16
2023-02-07 16:17:04 +08:00
Hana
31015652b8
fix(napi): dropping Error should not call napi-sys if feature is set to noop ( #1477 )
2023-02-07 15:45:56 +08:00
LongYinan
c70c76d8f3
Release independent packages
...
napi@2.10.15
2023-02-06 00:59:55 +08:00
LongYinan
7613d669fb
chore(napi): enhance the error messages while converting types failed ( #1473 )
2023-02-06 00:52:59 +08:00
LongYinan
dc372d9153
Release independent packages
...
napi@2.10.14
napi-derive@2.10.1
2023-01-31 20:41:12 +08:00
LongYinan
3bd2bf40b1
fix(napi): run_script return type ( #1467 )
2023-01-31 20:36:59 +08:00
LongYinan
3158cb058f
fix(napi-derive): incorrect Task output type in some cases ( #1466 )
2023-01-31 20:10:04 +08:00
LongYinan
47a0d1af3b
Release independent packages
...
napi@2.10.13
2023-01-28 21:59:31 +08:00
LongYinan
e9de5681be
fix(napi): also apply electron external data fallback to lowlevel APIs ( #1458 )
...
* fix(napi): also apply electron external data fallback to lowlevel APIs
* chore: allow uninlined_format_args in tests
2023-01-28 21:31:57 +08:00
LongYinan
fde2d649ee
Release independent packages
...
napi@2.10.12
2023-01-28 14:55:40 +08:00
LongYinan
adb2508fdf
fix(napi): add missing NoExternalBuffersAllowed ( #1457 )
2023-01-28 14:53:31 +08:00
LongYinan
134eb8e19b
Release independent packages
...
napi@2.10.11
2023-01-25 09:57:25 +08:00
LongYinan
548f288722
fix(napi): fallback to copy arraybuffer if zero copy is not allowed ( #1455 )
2023-01-24 22:39:46 +08:00
LongYinan
b42410182e
Release independent packages
...
napi@2.10.10
napi-derive@2.10.0
2023-01-24 21:59:53 +08:00
LongYinan
ab81f4126b
chore(napi-derive): allow unsafe async &mut self ( #1453 )
2023-01-24 20:41:57 +08:00
LongYinan
e3adf5dac4
fix(napi): unhandled promise rejection while using EitherN<Promise<..>> ( #1452 )
2023-01-24 19:07:33 +08:00
LongYinan
54dd120880
fix(napi): add UnknownReturnValue to use in call_async scenario ( #1451 )
2023-01-24 17:41:36 +08:00
LongYinan
694f761fd9
fix(napi): throw fatal error if cast return value failed ( #1450 )
2023-01-24 16:32:40 +08:00
LongYinan
c8352a1fb0
feat(napi-derive): allow partial implement From/To Napivalue for Object ( #1448 )
2023-01-24 14:51:16 +08:00
LongYinan
e79eb34118
feat(napi-derive): generate ThreadsafeFunction types ( #1449 )
2023-01-24 14:25:05 +08:00
LongYinan
02daa90058
chore(napi): implement FromNapiValue for ThreadsafeFunction ( #1447 )
2023-01-24 12:16:24 +08:00
LongYinan
c51d657224
Release independent packages
...
- napi@2.10.9
- napi-sys@2.2.3
2023-01-19 17:30:12 +08:00
LongYinan
fda0aa0eec
fix(napi): fallback to copy buffer if zero copy is not allowed ( #1445 )
2023-01-19 17:26:59 +08:00
LongYinan
0848746534
Release independent packages
...
napi@2.10.8
2023-01-18 11:21:22 +08:00
LongYinan
6739ddda20
fix(napi): remove useless aquire while creating ThreadsafeFunction ( #1442 )
2023-01-18 11:20:47 +08:00
LongYinan
3db49adcdc
Release independent packages
...
napi@2.10.7
2023-01-17 00:06:43 +08:00
LongYinan
46f08ee6dd
fix(napi): missing From implementation for Bigint ( #1440 )
2023-01-17 00:05:19 +08:00
LongYinan
f14799f0b7
Release independent packages
...
napi-derive@2.9.5
2023-01-14 18:30:59 +08:00
Hana
78b6e1574a
fix(napi-derive): fix union type generation for ts function notation ( #1439 )
...
* fix(backend): fix union type generation for ts function notation
* chore: update snapshot
* fix: naming
2023-01-14 18:27:46 +08:00
LongYinan
be805b684d
Release independent packages
...
napi-derive@2.9.4
2023-01-13 16:57:47 +08:00
Hana
976acc773e
fix(napi-derive): remove ts type on field attrs ( #1436 )
2023-01-12 13:32:59 +08:00
LongYinan
38390dbef9
Release independent packages
...
napi@2.10.6
2023-01-11 22:02:19 +08:00
HeYunfei
d06bd23351
fix(napi): should correctly return while dropping Buffer ( #1434 )
2023-01-11 20:09:39 +08:00
LongYinan
dc3a4c9f25
feat(napi): refactor ThreadsafeFunction to allow get return value of it ( #1427 )
2023-01-11 18:54:45 +08:00
LongYinan
5492a0b9e9
fix(napi): delete reference should be after global custom gc ( #1433 )
2023-01-11 17:31:03 +08:00
LongYinan
3d3fa533d9
Release independent packages
...
napi@2.10.5
2023-01-09 17:21:54 +08:00
LongYinan
ad3ac5abc7
fix(napi): array buffer drop notify never be called in cloned buffer ( #1424 )
2023-01-09 16:58:26 +08:00
overlookmotel
ce2a29fca7
fix(napi): arraybuffer memory leak ( #1420 )
2023-01-09 14:47:36 +08:00
LongYinan
76a16be0eb
Release independent packages
...
napi@2.10.4
2022-12-29 16:00:09 +08:00
LongYinan
877d631d99
fix(napi): only delete reference in custom gc
2022-12-29 14:48:00 +08:00
LongYinan
d2a492a2d0
fix(napi): require higher version of once_cell
2022-12-29 14:27:33 +08:00
Xiaopeng Li
ce4c28412a
fix(napi): promise leak ( #1403 )
...
Co-authored-by: Xiaopeng Li <lixiaopeng.jetspark@bytedance.com>
2022-12-29 00:15:55 +08:00
LongYinan
1bcb3a3628
Release independent packages
...
napi@2.10.3
2022-12-19 19:49:11 +08:00
LongYinan
ef5dffca80
fix(napi): add back custom gc for Send Buffer ( #1399 )
2022-12-19 19:11:53 +08:00
LongYinan
328b84eb8f
style: run format
2022-12-17 00:14:05 +08:00
LongYinan
f8d1dcee5b
Merge pull request #1395 from napi-rs/tweaks-code
...
chore(napi): reduce Mutex usage while loading addon
2022-12-16 23:13:36 +08:00
LongYinan
e370dee545
chore(napi): remove useless de_init
2022-12-16 21:50:49 +08:00
LongYinan
6e4b16fe5d
style: clippy fix
2022-12-16 20:19:39 +08:00
LongYinan
968d9e10b1
chore(napi): fix tokio destroy logic
2022-12-16 20:07:22 +08:00
F001
d2531352aa
feat(napi): add "run_script" for "Env" ( #1393 )
...
* add "run_script" for "Env"
* Apply suggestions from code review
use `AsRef<str>` instead of `&str`
Co-authored-by: LongYinan <lynweklm@gmail.com>
* use `AsRef<str>` instead of `&str`
Co-authored-by: LongYinan <lynweklm@gmail.com>
2022-12-16 15:56:36 +08:00
LongYinan
e88fbcc404
chore(napi): remove more thread_local usage
2022-12-16 15:54:29 +08:00
LongYinan
5bd6c78b5a
chore(napi): expose tokio runtime
2022-12-16 14:35:30 +08:00
LongYinan
c01bcecb2b
chore(napi): reduce the complex about destroying tokio runtime
2022-12-16 14:32:32 +08:00
Patrick Pilch
486ce35c82
fix(napi): napi_create_async_work incorrect argument (napi-rs#1392) ( #1396 )
...
The third argument to `napi_create_async_work` (async_resource_name)
should be a `napi_value` that corresponds to a null-terminated utf-8
string.
This resolves errors running Next.js with GraalVM.
oracle/graal#5582
oracle/graal#5581
2022-12-16 13:59:15 +08:00
LongYinan
a9f9dbb232
chore(napi): reduce Mutex usage while loading addon
2022-12-16 13:41:16 +08:00
LongYinan
f6ac154378
Release independent packages
...
napi-derive@2.9.3
2022-12-09 18:59:54 +08:00
Simon Vandel Sillesen
00b09bca6e
fix(napi): better error message for #[napi(catch_unwind)]
( #1383 )
...
Before, the JS error would only have `Any { .. }`
2022-12-09 18:37:10 +08:00
LongYinan
25fb299ac6
Release independent packages
...
napi@2.10.2
napi-derive@2.9.2
2022-12-09 00:41:03 +08:00
nihohit
1cf32631bf
fix(napi): typed arrays ref shouldn't use offset. ( #1376 )
...
Notice from the n-api docs that the data returned from
`napi_get_typedarray_info` is already adjusted by the byte offset.
https://nodejs.org/api/n-api.html#napi_get_typedarray_info
This means that when `as_ref`/`as_mut` apply the byte offset, the
offset is in practice applied twice.
This wasn't caught in tests because no test tried to modify a typed
array with a byte offset, and the test didn't us the typed array
structs, only `JsTypedArray`. If you want, I can modify the rest of the
functions in examples/napi-compt-mode/src/arraybuffers.rs
and the matching tests, to test all typed arrays.
IMO the `byte_offset` field can be removed entirely from the struct,
but I wanted to submit a minimal PR.
2022-11-30 20:54:13 +08:00
LongYinan
573f67b90f
chore(napi-derive): make_ref tweaks ( #1371 )
2022-11-22 23:17:44 +08:00
Jacob Kiesel
618d0f8046
fix(napi-derive): unsound behavior while using reference and async together
2022-11-22 00:17:19 +08:00
Simon Laux
035def0600
fix(napi): return the join handle when spawning a tokio task. ( #1351 )
...
we need this to be able to safely drop an struct,
that makes use of an async task.
the drop function needs to be able to call `.abort()`
on the join handle to avoid memory corruption and undefined bahviour.
2022-11-15 11:50:25 +08:00
Simon Laux
b0c248ad7e
chore(napi): expose tokio runtime's block_on function ( #1352 )
2022-11-15 11:49:46 +08:00
LongYinan
9816a77729
Release independent packages
...
napi@2.10.1
2022-11-12 13:39:04 +08:00
LongYinan
3dde26bcef
chore(napi): including type message in error message ( #1350 )
2022-10-24 00:16:30 +08:00
Wodann
77060adb3d
fix(napi): BigInt::get_u64 lossless check ( #1348 )
2022-10-22 11:16:08 +08:00
LongYinan
a12bdc4359
Release independent packages
...
- napi@2.10.0
2022-10-04 17:17:13 +08:00
Devon Govett
5541d650a9
feat(napi): add threadsafe deferred values ( #1306 )
2022-10-03 13:00:48 +08:00
LongYinan
a5a04a4e54
fix(napi): make Buffer/ArrayBuffer truely Send/Sync safe
2022-10-03 11:34:46 +08:00
LongYinan
47de6301ee
fix(napi): should also delete the reference while dropping the Buffer
2022-10-02 10:14:25 +08:00
user.tax
e54c37a0b1
feat(napi): add support for Vec<(std::string::String, u16)> and some other small change ( #1320 )
2022-09-20 12:13:07 +08:00
user.tax
0d49b45ea9
feat(napi): add impl<T: Into<Vec<u8>>> From<T> for Uint8Array ( #1317 )
...
Co-authored-by: any <any@user.tax>
2022-09-16 23:15:29 +08:00
LongYinan
ea18170779
fix(napi): propagation error in function call ( #1315 )
2022-09-14 19:30:43 +08:00
Devon Govett
5ba70b0e1a
fix(napi): improve error propagation ( #1303 )
2022-09-14 17:03:11 +08:00
LongYinan
f3c203d46e
Release independent packages
...
napi@2.9.1
napi-derive@2.9.1
2022-09-08 17:27:35 +08:00
Dennis Duda
fc63ba8b52
fix(napi): some of the unsoundness in Buffer
( #1294 )
...
* fix leaked napi refcount in `Buffer` when cloning
Cloning unconditionally increased the refcount in `Buffer::clone`, but only called `napi_reference_unref` on dropping the last Buffer (the one with `strong_count == 1`). This means that the refcount will never drop back to zero after cloning, leaking the Buffer.
This commit changes it to also unconditionally unref the buffer.
* fix multiple sources of UB in `Buffer`
- `slice::from_raw_parts` may never be created with a null pointer, but `napi_get_buffer_info` was not sufficiently checked → UB when passing an empty Buffer
- `&'static mut [u8],` is invalid, as it certainly doesn't live for `'static`
Switching to `NonNull<u8>` and a `len` field fixes both of these.
- I also don't really understand how the `impl ToNapiValue for &mut Buffer` could have been sound. It creates an entirely new `Arc`, but reuses the same `Vec` allocation, leading to... a double free of the `Vec` on drop? I have replaced it with a simple call to `clone` instead.
* remove overcomplicated bool and drop impl
As far as I can tell, by just removing the bool and letting the drop code do its thing we clean up correctly in all cases. Because `napi_create_external_buffer` gets an owned `Buffer` attached to it via the Box, we can rely on `from_raw` retrieving it in the `drop_buffer` function.
2022-09-05 13:04:43 +08:00