naskya/test
1
0
Code Issues 180 Projects Packages Wiki Activity Actions

Remove hidden visibility in backend #175

New issue
Open
opened 2025-02-05 20:52:16 +09:00 by naskya · 3 comments
naskya commented 2025-02-05 20:52:16 +09:00
Owner
Copy link

What type of refactoring is this?

  • label: Server
  • label: Refactor

What parts of the code do you think should be refactored?

Remove hidden visibility from note.

Why should the code be refactored that way?

Considering that the hidden type was introduced for import and !10738 is merged, it is possible to consider removing it.

However, it seems that the complexity is not low at present, and it feels at the same level as rollback "enhance privacy of notes" which !10696 discussed.

Version

20240729

Instance

Contribution Guidelines

By submitting this issue, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have searched the issue tracker for similar requests, and this is not a duplicate.

Are you willing to refactor the code? (optional)

  • Yes, I will open a merge request that closes this ticket.
<!-- This issue template is for refactor proposals. There are other issue templates for bug reports, feature requests, and discussions, so please use them if this is not a refactor proposal. Also, you don't need to prefix the issue title with "Refactor:", because it's managed by issue labels. --> <!-- 💖 Thanks for taking the time to fill out this report! 💁 Having trouble with deployment? [Ask the support chat.](https://matrix.to/#/#firefish-community:nitro.chat) 🔒 Found a security vulnerability? [Please disclose it responsibly.](https://firefish.dev/firefish/firefish/-/blob/develop/SECURITY.md) 🤝 By submitting this feature request, you agree to follow our [Contribution Guidelines.](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) --> ## What type of refactoring is this? <!-- If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side. --> <!-- Uncomment (remove surrounding arrow signs) the following line(s) to specify the category of this issue. --> * label: Server <!-- * label: Client --> <!-- * label: Mobile --> <!-- * label: Third-party-client --> <!-- * label: Docs --> <!-- * label: Locale --> <!-- * label: Build from source --> <!-- * label: Container --> <!-- * label: Firefish API --> <!-- * label: Mastodon API --> <!-- Please do not edit the next line --> * label: Refactor ## What parts of the code do you think should be refactored? <!-- Please give us a brief description of what you'd like. --> Remove hidden visibility from note. ## Why should the code be refactored that way? <!-- Please give us a brief description of the reason of your proposal. --> Considering that the hidden type was introduced for import and !10738 is merged, it is possible to consider removing it. However, it seems that the complexity is not low at present, and it feels at the same level as rollback "enhance privacy of notes" which !10696 discussed. ## Version <!-- What version of firefish is your instance running? You can find this by clicking your instance's logo at the bottom left and then clicking instance information. --> 20240729 ## Instance <!-- What instance of Firefish are you using? --> ## Contribution Guidelines By submitting this issue, you agree to follow our [Contribution Guidelines](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) - [X] I agree to follow this project's Contribution Guidelines - [X] I have searched the issue tracker for similar requests, and this is not a duplicate. ## Are you willing to refactor the code? (optional) - [X] Yes, I will open a merge request that closes this ticket. <!-- Please tell us how to refactor the code. As noted in the contribution guidelines, there is a good chance that your merge request will not be merged if there is no agreement with the project maintainers. However, we are currently so understaffed that it is virtually impossible to respond to every single proposal. So, feel free to implement it if there is no response for more than a week or there is a thumbs-up emoji reaction from the project maintainer(s). Many thanks for your involvement! -->
naskya commented 2025-02-05 20:52:16 +09:00
Author
Owner
Copy link

Author: laozhoubuluo

Well, I will submit MR once I have completed the impact assessment.

*Author: laozhoubuluo* Well, I will submit MR once I have completed the impact assessment.
naskya commented 2025-02-05 20:52:16 +09:00
Author
Owner
Copy link

Author: naskya

I’d like to convert the existing hidden posts to home, remove hidden from the visibility enum (ALTER TYPE ...), and remove the visibility === "hidden" checks in the backend. I see no reason why we should keep this one.

*Author: naskya* I’d like to convert the existing `hidden` posts to `home`, remove `hidden` from the visibility enum (`ALTER TYPE ...`), and remove the `visibility === "hidden"` checks in the backend. I see no reason why we should keep this one.
naskya commented 2025-02-05 20:52:16 +09:00
Author
Owner
Copy link

Author: naskya

changed title from Remove hidden visibility {-from note-} to Remove hidden visibility {+in backend+}

*Author: naskya* changed title from **Remove hidden visibility {-from note-}** to **Remove hidden visibility {+in backend+}**
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
No results found.
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
naskya/test#175
No description provided.