naskya/test
1
0
Code Issues 180 Projects Packages Wiki Activity Actions

Add pull-to-reload to the notifications page #177

New issue
Open
opened 2025-02-05 20:52:17 +09:00 by naskya · 0 comments
naskya commented 2025-02-05 20:52:17 +09:00
Owner
Copy link

What type of feature is this?

  • label: Client
  • label: Mobile
  • label: Feature

What feature would you like implemented?

Add pull-to-reload feature to the notifications page

Why should we add this feature?

When I cherry-picked the pull-to-refresh feature from Misskey, there was a bug that messed up notifications (https://misskey.io/notes/9qhc3jnp7mo60f0v), so I didn’t add the MkPullToRefresh component to the notifications page. But *key’s streaming API is unstable and often disconnects, especially on mobile. It is annoying to have to reload the entire page, so I think we should try to add pull-to-reload to the notifications page again.

Version

v20240729

Instance

post.naskya.net

Contribution Guidelines

By submitting this issue, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have searched the issue tracker for similar requests, and this is not a duplicate.

Are you willing to implement this feature? (optional)

  • Yes, I will open a merge request that closes this ticket.
<!-- This issue template is for feature requests. There are other issue templates for bug reports, refactor proposals, and discussions, so please use them if this is not a feature request. Also, you don't need to prefix the issue title with "Feature:", because it's managed by issue labels. --> <!-- 💖 Thanks for taking the time to fill out this feature request! 💁 Having trouble with deployment? [Ask the support chat.](https://matrix.to/#/#firefish-community:nitro.chat) 🔒 Found a security vulnerability? [Please disclose it responsibly.](https://firefish.dev/firefish/firefish/-/blob/develop/SECURITY.md) 🤝 By submitting this refactor proposal, you agree to follow our [Contribution Guidelines.](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) --> ## What type of feature is this? <!-- If this happens on your device and has to do with the user interface, it's client-side. If this happens on either with the API or the backend, or you got a server-side error in the client, it's server-side. --> <!-- Uncomment (remove surrounding arrow signs) the following line(s) to specify the category of this issue. --> <!-- * label: Server --> * label: Client * label: Mobile <!-- * label: Third-party-client --> <!-- * label: Docs --> <!-- * label: Locale --> <!-- * label: Build from source --> <!-- * label: Container --> <!-- * label: Firefish API --> <!-- * label: Mastodon API --> <!-- Please do not edit the next line --> * label: Feature ## What feature would you like implemented? <!-- Please give us a brief description of what you'd like to be refactored. --> Add pull-to-reload feature to the notifications page ## Why should we add this feature? <!-- Please give us a brief description of why your feature is important. --> When I cherry-picked the pull-to-refresh feature from Misskey, there was a bug that messed up notifications (https://misskey.io/notes/9qhc3jnp7mo60f0v), so I didn’t add the `MkPullToRefresh` component to the notifications page. But *key’s streaming API is unstable and often disconnects, especially on mobile. It is annoying to have to reload the entire page, so I think we should try to add pull-to-reload to the notifications page again. ## Version <!-- What version of firefish is your instance running? You can find this by clicking your instance's logo at the bottom left and then clicking instance information. --> v20240729 ## Instance <!-- What instance of Firefish are you using? --> post.naskya.net ## Contribution Guidelines By submitting this issue, you agree to follow our [Contribution Guidelines](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) - [x] I agree to follow this project's Contribution Guidelines - [x] I have searched the issue tracker for similar requests, and this is not a duplicate. ## Are you willing to implement this feature? (optional) - [ ] Yes, I will open a merge request that closes this ticket. <!-- Please tell us how to implement this feature. As noted in the contribution guidelines, there is a good chance that your merge request will not be merged if there is no agreement with the project maintainers. However, we are currently so understaffed that it is virtually impossible to respond to every single proposal. So, feel free to implement it if there is no response for more than a week or there is a thumbs-up emoji reaction from the project maintainer(s). Many thanks for your involvement! -->
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
No results found.
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
naskya/test#177
No description provided.