Remote pinned posts are dropped if any of them are followers-only #180
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What type of issue is this?
label: Server
label: Bug
What happened?
Originally thought this was an iceshrimp.net issue (seen here). (this is also a duplicate of this iceshrimp issue as this is *key-wide.)
as described in that issue, if a remote user has a pinned post that is followers only, all pins from that user will be dropped.
Example being this note

What did you expect to happen?
Regardless of note visibility, all pinned posts should be accepted.
Steps to reproduce the issue
Reproduces how often
Always
What did you try to solve the issue / Do you have any insights
I have not looked into the backend myself for any fixes yet.
Version
20240905
Instance
https://f.619.hu/
How do you deploy Firefish on your server? (server-side issues only)
N/A
What operating system are you using? (Server-side issues only)
N/A
Contribution Guidelines
By submitting this issue, you agree to follow our Contribution Guidelines
Are you willing to fix this bug? (optional)
I am unsure exactly where this happens in the backend, as i havent looked myself, so i cant really propose a fix.
Author: nelle
iceshrimp fixed this issue in:
https://iceshrimp.dev/iceshrimp/iceshrimp/pulls/573
iceshrimp/iceshrimp@34823aa7b8to quote mia of void rehab: "the resolver used for resolving pinned posts has no local user attached to it, so it requests the followers only post using the instance actor, which isn't following the account"