Remote pinned posts are dropped if any of them are followers-only #180

Open
opened 2025-02-05 20:52:20 +09:00 by naskya · 1 comment
Owner

What type of issue is this?

  • label: Server

  • label: Bug

What happened?

Originally thought this was an iceshrimp.net issue (seen here). (this is also a duplicate of this iceshrimp issue as this is *key-wide.)

as described in that issue, if a remote user has a pinned post that is followers only, all pins from that user will be dropped.

Example being this note
Screenshot_20240910_183921

What did you expect to happen?

Regardless of note visibility, all pinned posts should be accepted.

Steps to reproduce the issue

  1. Make and pin a followers only post
  2. Make and pin an unlisted/public post
  3. On a *key/firefish instance, update the remote user information, and look for pinned posts

Reproduces how often

Always

What did you try to solve the issue / Do you have any insights

I have not looked into the backend myself for any fixes yet.

Version

20240905

Instance

https://f.619.hu/

How do you deploy Firefish on your server? (server-side issues only)

N/A

What operating system are you using? (Server-side issues only)

N/A

Contribution Guidelines

By submitting this issue, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have searched the issue tracker for similar issues, and this is not a duplicate.

Are you willing to fix this bug? (optional)

  • Yes, I will open a merge request that closes this ticket.

I am unsure exactly where this happens in the backend, as i havent looked myself, so i cant really propose a fix.

## What type of issue is this? * label: Server * label: Bug ## What happened? Originally thought this was an iceshrimp.net issue (seen [here](https://issues.iceshrimp.dev/issue/ISH-469/Pinned-posts-dont-federate-with-key/)). (this is also a duplicate of [this iceshrimp issue](https://iceshrimp.dev/iceshrimp/iceshrimp/issues/567) as this is *key-wide.) as described in that issue, if a remote user has a pinned post that is followers only, all pins from that user will be dropped. Example being [this note](https://limbo.town/notes/9y0oyc6uh9ckqr95) ![Screenshot_20240910_183921](/uploads/73a2a7baed1db69300c797c28e58e7e2/Screenshot_20240910_183921.png) ## What did you expect to happen? Regardless of note visibility, all pinned posts should be accepted. ## Steps to reproduce the issue 1. Make and pin a followers only post 2. Make and pin an unlisted/public post 3. On a *key/firefish instance, update the remote user information, and look for pinned posts ## Reproduces how often Always ## What did you try to solve the issue / Do you have any insights I have not looked into the backend myself for any fixes yet. ## Version 20240905 <details> ### Instance https://f.619.hu/ ### How do you deploy Firefish on your server? (server-side issues only) N/A ### What operating system are you using? (Server-side issues only) N/A </details> ## Contribution Guidelines By submitting this issue, you agree to follow our [Contribution Guidelines](https://firefish.dev/firefish/firefish/-/blob/develop/CONTRIBUTING.md) - [X] I agree to follow this project's Contribution Guidelines - [X] I have searched the issue tracker for similar issues, and this is not a duplicate. ## Are you willing to fix this bug? (optional) - [ ] Yes, I will open a merge request that closes this ticket. I am unsure exactly where this happens in the backend, as i havent looked myself, so i cant really propose a fix.
Author
Owner

Author: nelle

iceshrimp fixed this issue in:

https://iceshrimp.dev/iceshrimp/iceshrimp/pulls/573
iceshrimp/iceshrimp@34823aa7b8

to quote mia of void rehab: "the resolver used for resolving pinned posts has no local user attached to it, so it requests the followers only post using the instance actor, which isn't following the account"

*Author: nelle* iceshrimp fixed this issue in: https://iceshrimp.dev/iceshrimp/iceshrimp/pulls/573 https://iceshrimp.dev/iceshrimp/iceshrimp/commit/34823aa7b88913c2018cf2fde11718f326a8b87d to quote mia of void rehab: "the resolver used for resolving pinned posts has no local user attached to it, so it requests the followers only post using the instance actor, which isn't following the account"
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
naskya/test#180
No description provided.