From e8288f652504e01a11199924a0d5040cad5a0576 Mon Sep 17 00:00:00 2001 From: Matteias Collet Date: Sun, 16 Aug 2020 07:42:37 +0200 Subject: [PATCH] remove line number from warnings --- .github/workflows/build.yml | 2 +- scripts/compare_translations.js | 4 ++-- scripts/inject_codes.js | 16 ++++++++-------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a8226ba..9832fe1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,4 +1,4 @@ -name: Pull Request +name: Build on: push: diff --git a/scripts/compare_translations.js b/scripts/compare_translations.js index 887a47a..71c9153 100644 --- a/scripts/compare_translations.js +++ b/scripts/compare_translations.js @@ -52,8 +52,8 @@ translations.forEach((t) => { const value = getNestedProperty(t.values, p); if (value == null || typeof value !== 'string') { console.warn(`${t.lang} is missing a translation at '${p}'`); - console.warn( - `::warning file=compare_translations.js,line=55,col=6::${t.lang} is missing a translation at '${p}'`, + console.log( + `::warning file=compare_translations.js::${t.lang} is missing a translation at '${p}'`, ); } }); diff --git a/scripts/inject_codes.js b/scripts/inject_codes.js index b697850..a0ae02e 100644 --- a/scripts/inject_codes.js +++ b/scripts/inject_codes.js @@ -103,8 +103,8 @@ const validateXML = (xmlString) => { console.warn( `Missing title translation for code '${codeTitle.textContent}' and locale ${localeIdentifiers[j]}`, ); - console.warn( - `::warning file=inject_codes.js,line=107,col=10::Missing title translation for code '${codeTitle.textContent}' and locale ${localeIdentifiers[j]}`, + console.log( + `::warning file=inject_codes.js::Missing title translation for code '${codeTitle.textContent}' and locale ${localeIdentifiers[j]}`, ); } @@ -118,8 +118,8 @@ const validateXML = (xmlString) => { console.warn( `Missing description translation for code '${codeTitle.textContent}' and locale ${localeIdentifiers[j]}`, ); - console.warn( - `::warning file=inject_codes.js,line=122,col=10::Missing description translation for code '${codeTitle.textContent}' and locale ${localeIdentifiers[j]}`, + console.log( + `::warning file=inject_codes.js::Missing description translation for code '${codeTitle.textContent}' and locale ${localeIdentifiers[j]}`, ); } @@ -136,8 +136,8 @@ const validateXML = (xmlString) => { console.warn( `Missing source on code '${codeTitle.textContent}' for version ${CODE_VERSIONS[j]}`, ); - console.warn( - `::warning file=inject_codes.js,line=140,col=10::Missing source on code '${codeTitle.textContent}' for version ${CODE_VERSIONS[j]}`, + console.log( + `::warning file=inject_codes.js::Missing source on code '${codeTitle.textContent}' for version ${CODE_VERSIONS[j]}`, ); } @@ -168,8 +168,8 @@ const readTextNode = (node, identifier, lang = null, fallbackLang = null) => { const codeTitle = node.querySelector(`title[lang='en-US']`); console.warn(`No translation found for code '${codeTitle.textContent}' for locale ${lang}`); - console.warn( - `::warning file=inject_codes.js,line=172,col=6::No translation found for code '${codeTitle.textContent}' for locale ${lang}`, + console.log( + `::warning file=inject_codes.js::No translation found for code '${codeTitle.textContent}' for locale ${lang}`, ); if (!fallbackLang) throw new Error(`No localized ${identifier} found on ${node.textContent}`);