supnas/cinny
2
1
Fork 0
Code Issues 3 Pull requests Activity

Update node to latest LTS (#1687)

Browse source 
* Update node to latest LTS

* Update node in Dockerfile
This commit is contained in:
Krishan 2024-04-25 00:31:01 +10:00 committed by GitHub
parent 743e916d12
commit 3025133d18
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
.github/workflows/build-pull-request.yml vendored
View file

@ -16,13 +16,13 @@ jobs:
- name: Setup node - name: Setup node
uses: actions/setup-node@v3.8.1 uses: actions/setup-node@v3.8.1
with: with:
node-version: 18.12.1 node-version: 20.12.2
cache: "npm" cache: 'npm'
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
- name: Build app - name: Build app
env: env:
NODE_OPTIONS: "--max_old_space_size=4096" NODE_OPTIONS: '--max_old_space_size=4096'
run: npm run build run: npm run build
- name: Upload artifact - name: Upload artifact
uses: actions/upload-artifact@v3.1.2 uses: actions/upload-artifact@v3.1.2

10
.github/workflows/netlify-dev.yml vendored
View file

@ -3,7 +3,7 @@ name: Deploy to Netlify (dev)
on: on:
push: push:
branches: branches:
- dev - dev
jobs: jobs:
deploy-to-netlify: deploy-to-netlify:
@ -15,19 +15,19 @@ jobs:
- name: Setup node - name: Setup node
uses: actions/setup-node@v3.8.1 uses: actions/setup-node@v3.8.1
with: with:
node-version: 18.12.1 node-version: 20.12.2
cache: "npm" cache: 'npm'
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
- name: Build app - name: Build app
env: env:
NODE_OPTIONS: "--max_old_space_size=4096" NODE_OPTIONS: '--max_old_space_size=4096'
run: npm run build run: npm run build
- name: Deploy to Netlify - name: Deploy to Netlify
uses: nwtgck/actions-netlify@7a92f00dde8c92a5a9e8385ec2919775f7647352 uses: nwtgck/actions-netlify@7a92f00dde8c92a5a9e8385ec2919775f7647352
with: with:
publish-dir: dist publish-dir: dist
deploy-message: "Dev deploy ${{ github.sha }}" deploy-message: 'Dev deploy ${{ github.sha }}'
enable-commit-comment: false enable-commit-comment: false
github-token: ${{ secrets.GITHUB_TOKEN }} github-token: ${{ secrets.GITHUB_TOKEN }}
production-deploy: true production-deploy: true

8
.github/workflows/prod-deploy.yml vendored
View file

@ -14,19 +14,19 @@ jobs:
- name: Setup node - name: Setup node
uses: actions/setup-node@v3.8.1 uses: actions/setup-node@v3.8.1
with: with:
node-version: 18.12.1 node-version: 20.12.2
cache: "npm" cache: 'npm'
- name: Install dependencies - name: Install dependencies
run: npm ci run: npm ci
- name: Build app - name: Build app
env: env:
NODE_OPTIONS: "--max_old_space_size=4096" NODE_OPTIONS: '--max_old_space_size=4096'
run: npm run build run: npm run build
- name: Deploy to Netlify - name: Deploy to Netlify
uses: nwtgck/actions-netlify@7a92f00dde8c92a5a9e8385ec2919775f7647352 uses: nwtgck/actions-netlify@7a92f00dde8c92a5a9e8385ec2919775f7647352
with: with:
publish-dir: dist publish-dir: dist
deploy-message: "Prod deploy ${{ github.ref_name }}" deploy-message: 'Prod deploy ${{ github.ref_name }}'
enable-commit-comment: false enable-commit-comment: false
github-token: ${{ secrets.GITHUB_TOKEN }} github-token: ${{ secrets.GITHUB_TOKEN }}
production-deploy: true production-deploy: true

2
Dockerfile
View file

@ -1,5 +1,5 @@
## Builder ## Builder
FROM node:18.12.1-alpine3.15 as builder FROM node:20.12.2-alpine3.18 as builder
WORKDIR /src WORKDIR /src

2
README.md
View file

@ -86,7 +86,7 @@ UeGsouhyuITLwEhScounZDqop+Dx
## Local development ## Local development
> We recommend using a version manager as versions change very quickly. You will likely need to switch > We recommend using a version manager as versions change very quickly. You will likely need to switch
between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Also recommended nodejs version Hydrogen LTS (v18). between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Recommended nodejs version is Iron LTS (v20).
Execute the following commands to start a development server: Execute the following commands to start a development server:
```sh ```sh