LongYinan
aeb0b4766d
fix(napi): add back the typecheck logic that was accidentally removed in Object::get_named_property ( #1982 )
...
- Close https://github.com/napi-rs/napi-rs/issues/1641
2024-02-28 14:29:02 +08:00
Caleb Everett
95dd6ef485
refactor(cli): refactor js-binding to support easier bundling. ( #1957 )
...
* Refactor js-binding to support bundling single-package artifacts
The existsSync check breaks the bundlers I've tested (esbuild, webpack,
ncc), so you cannot bundle napi-rs packages that have all binarys in a
single package.
I've tested this change with both single package and multi package
libraries.
* Update snapshots
* Update CI
* Fix electron test
---------
Co-authored-by: Caleb ツ Everett <calebev@amazon.com>
Co-authored-by: LongYinan <lynweklm@gmail.com>
2024-02-26 15:46:07 +08:00
LongYinan
117e4ce153
fix(napi-derive): wrong dependency condition ( #1980 )
2024-02-25 15:25:42 +08:00
LongYinan
8ca1967bd8
feat(napi): impl BufferSlice and Uint8ClampedSlice ( #1979 )
2024-02-25 01:00:28 +08:00
LongYinan
f88a041fa3
feat(napi): impl chained Into for TypedArray types ( #1978 )
2024-02-25 00:58:27 +08:00
LongYinan
3e187151a6
fix(napi-derive): HashMap/IndexMap and slice generated types ( #1977 )
2024-02-25 00:56:30 +08:00
LongYinan
5af366b042
style(napi-derive): clippy fix ( #1976 )
2024-02-25 00:54:33 +08:00
LongYinan
71bbe0ef6f
fix(napi): remove useless create_reference in slice => TypedArray impl ( #1975 )
2024-02-25 00:52:30 +08:00
LongYinan
2fda360742
chore: fix renovate path and dedupe electron versions ( #1974 )
2024-02-25 00:50:22 +08:00
ebe97257a6
feat(napi-derive): add use_nullable attribute ( #1971 )
...
* feat(napi-derive): add use_nullable attribute
Co-authored-by: naskya <m@naskya.net>
* chore(napi-derive): update tests
Co-authored-by: naskya <m@naskya.net>
---------
Co-authored-by: naskya <m@naskya.net>
2024-02-24 21:49:54 +08:00
Louis
43415251b8
feat(napi): allow Reference as a class method param ( #1966 )
...
As of before this commit, there was a lock in the codegen preventing Reference
from being used as a function argument outside of a Reference<Self>.
This changes it, allowing Reference of any class to be added as a class method
argument anywhere. It has the same limitations as reference, as in it requires
the class to have been created with a factory or constructor. This change
implements FromNapiValue on Reference, which will unwrap the class and call the
existing from_value_ptr method. It also updated typegen so that we only emit
the reference type if we're in an impl block that doesn't match the Reference
we're getting. This ensures that typegen works as expected with the previous
behaviour.
2024-02-22 22:37:50 +08:00
LongYinan
17f509f96e
chore(release): publish
...
- @napi-rs/cli@3.0.0-alpha.41
2024-02-22 19:01:28 +08:00
LongYinan
33cf208758
Release independent packages
...
napi@2.15.4
2024-02-22 19:01:18 +08:00
Tom Barham
ebd5eef267
fix(napi): require static lifetime on add_finalizer callback ( #1968 )
...
Co-authored-by: LongYinan <lynweklm@gmail.com>
2024-02-22 18:40:04 +08:00
Louis
5b5f616d81
fix(napi): no hard fail on ThreadsafeFunction::call_async ( #1970 )
...
For many reasons, in an app we can end up in a scenario where the thread / task that initially called the ThreadsafeFunction gets interrupted. This means that the receiver would get collected, should a ThreadsafeFunction be awaited on the said thread. This will create an error when the ThreadsafeFunction's callback will be called, and call a napi_fatal_error.
This change makes it so that if the send errors, this error is hidden and thus prevents any hard failure. If a ThreadsafeFunction is called in such a case, its output won't be used, but we'll still run all the logic to ensure it ran properly.
Fixes https://github.com/napi-rs/napi-rs/issues/1665 - cc @Brooooooklyn
2024-02-22 17:34:10 +08:00
LongYinan
da99081ccf
fix(cli): allow more platform & arch fallback to wasm ( #1969 )
2024-02-22 16:42:33 +08:00
LongYinan
0306e3045a
fix(cli): fallback to wasm32 if platform is not support ( #1967 )
2024-02-21 23:48:29 +08:00
LongYinan
8855f18f50
Release independent packages
...
napi@2.15.3
2024-02-21 23:16:27 +08:00
dependabot[bot]
60d07338fd
chore(deps): bump ip from 1.1.8 to 1.1.9 ( #1965 )
...
Bumps [ip](https://github.com/indutny/node-ip ) from 1.1.8 to 1.1.9.
<details>
<summary>Commits</summary>
<ul>
<li><a href="1ecbf2fd8c6a3ada9b47https://github.com/indutny/node-ip/compare/v1.1.8...v1.1.9 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/napi-rs/napi-rs/network/alerts ).
</details>
2024-02-21 10:59:59 +08:00
Louis
9391196eef
fix(napi): prevent memory leak when Custom GC is used ( #1963 )
...
There is a piece of custom logic that has been added a while back to ensure
that Buffers can be sent across threads, and be dropped properly. This involves
a custom GC that runs on NodeJS's current thread (per my understanding). The
logic to drop the buffer on that custom GC differed from the one in the Drop
impl. This meant that everytime Node sent a buffer back to a napi-rs function,
the reference wouldn't be cleaned up properly, and it would leak (96 bytes per
Reference on an ARM MacOS machine).
This commit updates the logic in the custom GC so that it matches the one in
the Drop impl. This worked locally, and fixed any occurence of the leak I could
find.
2024-02-20 20:36:21 +08:00
Louis
90e3a349db
fix: remove outdated rustdoc about tokio channels ( #1961 )
...
This seems to be a relic of when napi-rs used channels to send data to the
tokio runtime. This removes the outdated doc, as this could be misleading if
one wants to understand what those channels are about.
2024-02-20 16:36:29 +08:00
renovate[bot]
1d93461dcd
chore(deps): update dependency electron to v29 ( #1962 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [electron](https://togithub.com/electron/electron ) | [`^28.2.0` -> `^29.0.0`](https://renovatebot.com/diffs/npm/electron/28.2.1/29.0.0 ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>electron/electron (electron)</summary>
### [`v29.0.0`](https://togithub.com/electron/electron/releases/tag/v29.0.0 ): electron v29.0.0
[Compare Source](https://togithub.com/electron/electron/compare/v28.2.3...v29.0.0 )
### Release Notes for v29.0.0
#### Stack Upgrades
- Chromium `122.0.6261.39`
- [New in 122](https://developer.chrome.com/blog/new-in-chrome-122/ )
- [New in 121](https://developer.chrome.com/blog/new-in-chrome-121/ )
- Node `20.9.0`
- [Node 20.9.0 blog post](https://nodejs.org/en/blog/release/v20.9.0/ )
- V8 `12.2`
#### Breaking Changes
- Functions called over the `contextBridge` are now called with the expected receiver (`this`). [#​39978](https://togithub.com/electron/electron/pull/39978 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40262 ), [28](https://togithub.com/electron/electron/pull/40263 ))</span>
- The `gpu-process-crashed` event on `app` has been deprecated. [#​40169](https://togithub.com/electron/electron/pull/40169 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40195 ))</span>
- The deprecated `gpu-process-crashed` event on `app` has been removed. [#​40255](https://togithub.com/electron/electron/pull/40255 )
- The deprecated `renderer-process-crashed` event on `app` and `crashed` event on `WebContents` and `<webview>` have been removed. [#​40115](https://togithub.com/electron/electron/pull/40115 )
#### Features
##### Additions
- Added `WebContentsView` and `BaseWindow`, replacing the now-deprecated `BrowserView` APIs. [#​40759](https://togithub.com/electron/electron/pull/40759 )
- Added `keyboardLock` to `ses.setPermissionRequestHandler(handler)`. [#​40369](https://togithub.com/electron/electron/pull/40369 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40458 ), [27](https://togithub.com/electron/electron/pull/40459 ), [28](https://togithub.com/electron/electron/pull/40460 ))</span>
- Added an option in `protocol.registerSchemesAsPrivileged` to allow V8 code cache in custom schemes. [#​40544](https://togithub.com/electron/electron/pull/40544 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40708 ), [28](https://togithub.com/electron/electron/pull/40709 ))</span>
- Added net module to utility process. [#​40890](https://togithub.com/electron/electron/pull/40890 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40968 ), [28](https://togithub.com/electron/electron/pull/40967 ))</span>
- Added new [Electron Fuse](https://www.electronjs.org/docs/latest/tutorial/fuses ) that opts the `file://` protocol into more secure and restrictive behaviour that matches Chromium. [#​40372](https://togithub.com/electron/electron/pull/40372 )
- Added new `webUtils.getPathForFile` method to replace `File.path` augmentation. [#​38776](https://togithub.com/electron/electron/pull/38776 )
- Added support for configuring `use_remote_checksums` via `.npmrc`. [#​40253](https://togithub.com/electron/electron/pull/40253 )
- Migrated `app.{set|get}LoginItemSettings(settings)` to use Apple's new recommended underlying framework on macOS. [#​37244](https://togithub.com/electron/electron/pull/37244 )
- This PR adds several properties to the `display` object including `detected`, `maximumCursorSize`, and `nativeOrigin`. [#​40497](https://togithub.com/electron/electron/pull/40497 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40554 ))</span>
##### Removed/Deprecated
- Removed extraneous dlls from Windows zip files. [#​41129](https://togithub.com/electron/electron/pull/41129 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/41128 ))</span>
#### Fixes
- Added support for `ThumbnailCapturerMac` and `ScreenCaptureKitStreamPickerSonoma` chromium feature flags to bypass deprecated API warning on macOS 14.4. [#​41329](https://togithub.com/electron/electron/pull/41329 )
- Fixed Electron 29.0.0-beta.3 regression that could pop up context menus in the wrong location. [#​41296](https://togithub.com/electron/electron/pull/41296 )
- Fixed an issue where `import.meta.url` did not work in the renderer process with `contextIsolation` enabled. [#​41265](https://togithub.com/electron/electron/pull/41265 )
- Fixed an issue where `original-fs` methods were not properly corrected for patched imports. [#​41238](https://togithub.com/electron/electron/pull/41238 )
- Fixed an issue where draggable regions didn't work across platforms. [#​41112](https://togithub.com/electron/electron/pull/41112 )
- Fixed crash in MessagePort::close. [#​41237](https://togithub.com/electron/electron/pull/41237 )
- Fixed the `GrantFileProtocolExtraPrivileges` not correctly preventing `fetch()` calls to `file://` URLs. [#​40864](https://togithub.com/electron/electron/pull/40864 )
##### Also in earlier versions...
- Apply module search paths restriction on worker and child process. [#​41138](https://togithub.com/electron/electron/pull/41138 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41139 ), [28](https://togithub.com/electron/electron/pull/41137 ))</span>
- Backported fix for AVX related crashes on certain linux machines. [#​40536](https://togithub.com/electron/electron/pull/40536 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40540 ), [27](https://togithub.com/electron/electron/pull/40541 ), [28](https://togithub.com/electron/electron/pull/40542 ))</span>
- CSS style `-webkit-app-region: drag;` has no effect in full screen mode. [#​41332](https://togithub.com/electron/electron/pull/41332 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41331 ), [28](https://togithub.com/electron/electron/pull/41330 ))</span>
- Fixed "will-navigate" not being emitted when pressing links in `chrome:` pages. [#​40390](https://togithub.com/electron/electron/pull/40390 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40524 ), [28](https://togithub.com/electron/electron/pull/40525 ))</span>
- Fixed `session.fromPartition()` key lookup bug. [#​41084](https://togithub.com/electron/electron/pull/41084 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/41083 ))</span>
- Fixed a crash resultant from trying to listen to power-related events before the `ready` event was emitted on Linux. [#​40925](https://togithub.com/electron/electron/pull/40925 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40922 ), [27](https://togithub.com/electron/electron/pull/40923 ), [28](https://togithub.com/electron/electron/pull/40924 ))</span>
- Fixed a crash that started occurring sporadically with some types of macOS window close. [#​41299](https://togithub.com/electron/electron/pull/41299 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/41298 ))</span>
- Fixed a partition alloc ref count check for higher MacOS versions. [#​40766](https://togithub.com/electron/electron/pull/40766 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40765 ))</span>
- Fixed a potential `async_hooks` crash when listening for the `restore` event on Windows after minimizing a maximized BrowserWindow. [#​41146](https://togithub.com/electron/electron/pull/41146 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41144 ), [28](https://togithub.com/electron/electron/pull/41145 ))</span>
- Fixed a potential crash when calling `dialog.showMessageBoxSync`. [#​41043](https://togithub.com/electron/electron/pull/41043 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41041 ), [28](https://togithub.com/electron/electron/pull/41042 ))</span>
- Fixed a potential issue with `async_hook` corruption in some error contexts. [#​40574](https://togithub.com/electron/electron/pull/40574 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40592 ), [27](https://togithub.com/electron/electron/pull/40593 ), [28](https://togithub.com/electron/electron/pull/40594 ))</span>
- Fixed a unexpectedly thrown error in some unsupported chrome extensions. [#​40500](https://togithub.com/electron/electron/pull/40500 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40512 ), [27](https://togithub.com/electron/electron/pull/40513 ), [28](https://togithub.com/electron/electron/pull/40514 ))</span>
- Fixed an error changing file format in `dialog.showOpenDialog` on macOS. [#​40308](https://togithub.com/electron/electron/pull/40308 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40347 ), [28](https://togithub.com/electron/electron/pull/40346 ))</span>
- Fixed an issue where Request objects did not correctly copy headers into fetches. [#​41019](https://togithub.com/electron/electron/pull/41019 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/41103 ))</span>
- Fixed an issue where WebViews could sometimes crash on unload. [#​40400](https://togithub.com/electron/electron/pull/40400 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40443 ), [27](https://togithub.com/electron/electron/pull/40444 ), [28](https://togithub.com/electron/electron/pull/40445 ))</span>
- Fixed an issue where Windows Toast notifications weren't properly dismissed from the Action Center on `notification.close()` if they'd previously been dismissed. [#​40197](https://togithub.com/electron/electron/pull/40197 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40242 ), [27](https://togithub.com/electron/electron/pull/40244 ), [28](https://togithub.com/electron/electron/pull/40243 ))</span>
- Fixed an issue where `MessagePorts` were not being correctly garbage collected when not referenced. [#​40189](https://togithub.com/electron/electron/pull/40189 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40201 ))</span>
- Fixed an issue where `inAppPurchase.getProducts` and `inAppPurchase.purchasedProduct` did not resolve as expected. [#​40957](https://togithub.com/electron/electron/pull/40957 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40955 ), [28](https://togithub.com/electron/electron/pull/40956 ))</span>
- Fixed an issue where `navigator.keyboard.lock()` did not work per [latest expected behavior](https://developer.chrome.com/blog/better-full-screen-mode ). [#​40365](https://togithub.com/electron/electron/pull/40365 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40387 ), [27](https://togithub.com/electron/electron/pull/40388 ), [28](https://togithub.com/electron/electron/pull/40389 ))</span>
- Fixed an issue where `select-usb-device` did not respect the `filter` option in `navigator.usb.requestDevice()`. [#​41197](https://togithub.com/electron/electron/pull/41197 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41196 ), [28](https://togithub.com/electron/electron/pull/41198 ))</span>
- Fixed an issue where `webContents.printToPDF` could fail when certain combinations of `margins` and `pageSize` values are passed. [#​41266](https://togithub.com/electron/electron/pull/41266 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/41267 ))</span>
- Fixed an issue where crashes in `node::Environment` destruction potentially wouldn't be propagated to the `
Service ` exit handler. [#​41301](https://togithub.com/electron/electron/pull/41301 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41300 ), [28](https://togithub.com/electron/electron/pull/41302 ))</span>
- Fixed an issue where devtools could not be re-opened. [#​40666](https://togithub.com/electron/electron/pull/40666 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40679 ))</span>
- Fixed an issue where font requests were incorrectly being sent to dev tools multiple times per resource. [#​40681](https://togithub.com/electron/electron/pull/40681 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40715 ), [28](https://togithub.com/electron/electron/pull/40688 ))</span>
- Fixed an issue where fully occluded windows would return an empty image from `webContents.capturePage()` on Windows and Linux. [#​39730](https://togithub.com/electron/electron/pull/39730 ) <span style="font-size:small;">(Also in [25](https://togithub.com/electron/electron/pull/40186 ), [26](https://togithub.com/electron/electron/pull/40187 ), [27](https://togithub.com/electron/electron/pull/40188 ), [28](https://togithub.com/electron/electron/pull/40185 ))</span>
- Fixed an issue where non-modal windows with vibrancy could have incorrectly rounded corners on Sonoma. [#​41037](https://togithub.com/electron/electron/pull/41037 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41035 ), [28](https://togithub.com/electron/electron/pull/41036 ))</span>
- Fixed an issue where the `printBackground` option in `webContents.printToPDF` did not work as expected. [#​41180](https://togithub.com/electron/electron/pull/41180 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/41179 ))</span>
- Fixed an issue where zoom level settings did not persist per-session for webviews. [#​40650](https://togithub.com/electron/electron/pull/40650 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41269 ), [28](https://togithub.com/electron/electron/pull/41268 ))</span>
- Fixed an issue with webContents interaction with fullscreen and WCO on macOS. [#​40179](https://togithub.com/electron/electron/pull/40179 ) <span style="font-size:small;">(Also in [25](https://togithub.com/electron/electron/pull/40220 ), [26](https://togithub.com/electron/electron/pull/40218 ), [27](https://togithub.com/electron/electron/pull/40217 ), [28](https://togithub.com/electron/electron/pull/40219 ))</span>
- Fixed app incorrectly activating panel windows on macOS Sonoma. [#​40307](https://togithub.com/electron/electron/pull/40307 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40465 ))</span>
- Fixed child window opening in non-active macOS apps. [#​40546](https://togithub.com/electron/electron/pull/40546 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40657 ), [27](https://togithub.com/electron/electron/pull/40658 ), [28](https://togithub.com/electron/electron/pull/40659 ))</span>
- Fixed default protocol handler behavior on Windows. [#​40908](https://togithub.com/electron/electron/pull/40908 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40909 ))</span>
- Fixed file paths passed to `shell.showItemInFolder` not being escaped in Linux. [#​40527](https://togithub.com/electron/electron/pull/40527 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40560 ), [27](https://togithub.com/electron/electron/pull/40561 ), [28](https://togithub.com/electron/electron/pull/40562 ))</span>
- Fixed forked child process not able to send IPC message under some cases on macOS. [#​41102](https://togithub.com/electron/electron/pull/41102 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/41099 ), [27](https://togithub.com/electron/electron/pull/41100 ), [28](https://togithub.com/electron/electron/pull/41101 ))</span>
- Fixed incorrect title bar shown on frameless transparent windows. [#​40862](https://togithub.com/electron/electron/pull/40862 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40868 ), [28](https://togithub.com/electron/electron/pull/40867 ))</span>
- Fixed loading nested ESM dependencies in `node_modules`
- Correctly support the `throwIfNoEntry` option in `fs.statSync`/`fs.lstatSync` in asar files. [#​40221](https://togithub.com/electron/electron/pull/40221 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40224 ))</span>
- Fixed macOS bug that causes window maximize button to be disabled in full-screen mode. [#​41029](https://togithub.com/electron/electron/pull/41029 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41027 ), [28](https://togithub.com/electron/electron/pull/41028 ))</span>
- Fixed on-screen-keyboard not hiding for webviews under some cases. [#​41149](https://togithub.com/electron/electron/pull/41149 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41151 ), [28](https://togithub.com/electron/electron/pull/41150 ))</span>
- Fixed problem with bounds of maximized window when toggle BrowserWindow.setResizable function. [#​40503](https://togithub.com/electron/electron/pull/40503 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40580 ), [27](https://togithub.com/electron/electron/pull/40581 ), [28](https://togithub.com/electron/electron/pull/40582 ))</span>
- Fixed resizing performance issue on macOS. [#​40577](https://togithub.com/electron/electron/pull/40577 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40584 ), [27](https://togithub.com/electron/electron/pull/40585 ), [28](https://togithub.com/electron/electron/pull/40586 ))</span>
- Fixed some redundant permission dialogs while screen sharing on Wayland. [#​40098](https://togithub.com/electron/electron/pull/40098 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40191 ), [27](https://togithub.com/electron/electron/pull/40193 ), [28](https://togithub.com/electron/electron/pull/40192 ))</span>
- Fixed the enabled/disabled behavior of the maximize/fullscreen button of macOS windows. [#​40897](https://togithub.com/electron/electron/pull/40897 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/40895 ), [28](https://togithub.com/electron/electron/pull/40896 ))</span>
- Prevent node mode to be used as script runner by other apps on macOS. [#​40579](https://togithub.com/electron/electron/pull/40579 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40738 ), [27](https://togithub.com/electron/electron/pull/40737 ), [28](https://togithub.com/electron/electron/pull/40710 ))</span>
- Unset all Node envs in node process when parent is a foreign process. [#​40881](https://togithub.com/electron/electron/pull/40881 ) <span style="font-size:small;">(Also in [26](https://togithub.com/electron/electron/pull/40882 ), [27](https://togithub.com/electron/electron/pull/40879 ), [28](https://togithub.com/electron/electron/pull/40880 ))</span>
- Use `activateIgnoringOtherApps` for focusing non-panels on macOS. [#​40570](https://togithub.com/electron/electron/pull/40570 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40621 ))</span>
#### Other Changes
- Re-enabled partition alloc on Mac. [#​33981](https://togithub.com/electron/electron/pull/33981 ) <span style="font-size:small;">(Also in [28](https://togithub.com/electron/electron/pull/40230 ))</span>
- Reverted new WebContentsView and BaseWindow APIs. [#​41060](https://togithub.com/electron/electron/pull/41060 )
- Security: backported fix for chromium:1517354. [#​40969](https://togithub.com/electron/electron/pull/40969 )
#### Notices
##### End of Support for 26.x.y
Electron 26.x.y has reached end-of-support as per the project's [support policy](https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy ). Developers and applications are encouraged to upgrade to a newer version of Electron.
### [`v28.2.3`](https://togithub.com/electron/electron/releases/tag/v28.2.3 ): electron v28.2.3
[Compare Source](https://togithub.com/electron/electron/compare/v28.2.2...v28.2.3 )
### Release Notes for v28.2.3
#### Fixes
- Fixed a crash that started occurring sporadically with some types of macOS window close. [#​41298](https://togithub.com/electron/electron/pull/41298 ) <span style="font-size:small;">(Also in [29](https://togithub.com/electron/electron/pull/41299 ))</span>
- Fixed an issue where `webContents.printToPDF` could fail when certain combinations of `margins` and `pageSize` values are passed. [#​41267](https://togithub.com/electron/electron/pull/41267 ) <span style="font-size:small;">(Also in [29](https://togithub.com/electron/electron/pull/41266 ))</span>
- Fixed an issue where crashes in `node::Environment` destruction potentially wouldn't be propagated to the `NodeService` exit handler. [#​41302](https://togithub.com/electron/electron/pull/41302 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41300 ), [29](https://togithub.com/electron/electron/pull/41301 ))</span>
- Fixed an issue where zoom level settings did not persist per-session for webviews. [#​41268](https://togithub.com/electron/electron/pull/41268 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41269 ))</span>
#### Other Changes
- Updated Chromium to 120.0.6099.283. [#​41262](https://togithub.com/electron/electron/pull/41262 )
### [`v28.2.2`](https://togithub.com/electron/electron/releases/tag/v28.2.2 ): electron v28.2.2
[Compare Source](https://togithub.com/electron/electron/compare/v28.2.1...v28.2.2 )
### Release Notes for v28.2.2
#### Fixes
- Fixed an issue where `select-usb-device` did not respect the `filter` option in `navigator.usb.requestDevice()`. [#​41198](https://togithub.com/electron/electron/pull/41198 ) <span style="font-size:small;">(Also in [27](https://togithub.com/electron/electron/pull/41196 ), [29](https://togithub.com/electron/electron/pull/41197 ))</span>
#### Other Changes
- Security: backported fix for [`1511567`](https://togithub.com/electron/electron/commit/1511567 ).
- Security: backported fix for [`1514777`](https://togithub.com/electron/electron/commit/1514777 ).
- Security: backported fix for [`1511085`](https://togithub.com/electron/electron/commit/1511085 ).
- Security: backported fix for [`1519980`](https://togithub.com/electron/electron/commit/1519980 ). [#​41178](https://togithub.com/electron/electron/pull/41178 )
- Updated Chromium to 120.0.6099.276. [#​41195](https://togithub.com/electron/electron/pull/41195 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View repository job log [here](https://developer.mend.io/github/napi-rs/napi-rs ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
2024-02-20 15:57:17 +08:00
LongYinan
9e44fd635b
fix(napi-derive): napi-derive-backend version
2024-02-20 15:17:43 +08:00
LongYinan
5232d9e836
chore(release): publish
...
- @napi-rs/cli@3.0.0-alpha.40
2024-02-19 19:10:51 +08:00
LongYinan
95af8065c0
Release independent packages
...
napi-build@2.1.2
2024-02-19 19:10:16 +08:00
LongYinan
ad35076d07
fix(cli,build): build params ( #1960 )
2024-02-19 18:09:34 +08:00
LongYinan
f7376f1e97
Release independent packages
...
napi-build@2.1.1
2024-02-18 22:05:20 +08:00
LongYinan
b461132f94
chore(release): publish
...
- @napi-rs/cli@3.0.0-alpha.39
2024-02-18 22:04:46 +08:00
LongYinan
08b1f689bf
feat(cli,build): support setjmp.h ( #1958 )
2024-02-18 21:45:19 +08:00
LongYinan
1951b60786
ci: upgrade toolchain in Docker ( #1956 )
2024-02-18 13:42:10 +08:00
LongYinan
97039b2f08
Release independent packages
...
- napi@2.15.2
- napi-derive@2.15.2
2024-02-17 22:58:31 +08:00
LongYinan
c49309fdc2
fix(napi): memory leak while using Reference ( #1954 )
...
- Close https://github.com/napi-rs/napi-rs/issues/1952
2024-02-17 22:14:27 +08:00
LongYinan
09efd416e5
fix(cli): set cxxflags while WASI_SDK_PATH exists ( #1955 )
2024-02-17 14:42:30 +08:00
LongYinan
20e0983288
style: apply clippy fix ( #1953 )
2024-02-17 14:12:24 +08:00
Andrew McClenaghan
6aae4bac0f
fix(cli): ensure cwd and outputDir are used for finding files ( #1949 )
2024-02-16 20:37:19 +08:00
LongYinan
5ac153388f
feat(napi): accept slice as TypedArray ( #1951 )
2024-02-15 23:40:45 +08:00
LongYinan
d7dc4dc5a2
feat(napi): extends the Map types interoperability ( #1950 )
2024-02-15 15:43:21 +08:00
renovate[bot]
642cecc759
chore(deps): update typescript-eslint monorepo to v7 (major) ( #1947 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint ) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin )) | [`^6.20.0` -> `^7.0.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.20.0/7.0.1 ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
| [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint ) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser )) | [`^6.20.0` -> `^7.0.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.20.0/7.0.1 ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) | [](https://docs.renovatebot.com/merge-confidence/ ) |
---
### Release Notes
<details>
<summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary>
### [`v7.0.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#701-2024-02-12 )
[Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.0.0...v7.0.1 )
##### 🩹 Fixes
- **eslint-plugin:** update peer dep for parser
##### ❤️ Thank You
- Tim Dorr
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
### [`v7.0.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#700-2024-02-12 )
[Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.21.0...v7.0.0 )
##### 🚀 Features
- ⚠️ bump ESLint, NodeJS, and TS minimum version requirements
- add support for flat configs
##### 🩹 Fixes
- **eslint-plugin:** \[prefer-find] stop throwing type errors when converting symbols to numbers
##### ⚠️ Breaking Changes
- ⚠️ bump ESLint, NodeJS, and TS minimum version requirements
##### ❤️ Thank You
- Brad Zacher
- Kirk Waiblinger
- StyleShit
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.21.0 (2024-02-05)
##### 🚀 Features
- export plugin metadata
- allow `parserOptions.project: false`
- **eslint-plugin:** add rule prefer-find
##### 🩹 Fixes
- **eslint-plugin:** \[no-unused-vars] don't report on types referenced in export assignment expression
- **eslint-plugin:** \[switch-exhaustiveness-check] better support for intersections, infinite types, non-union values
- **eslint-plugin:** \[consistent-type-imports] dont report on types used in export assignment expressions
- **eslint-plugin:** \[no-unnecessary-condition] handle left-hand optional with exactOptionalPropertyTypes option
- **eslint-plugin:** \[class-literal-property-style] allow getter when same key setter exists
- **eslint-plugin:** \[no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before `as` keyword
##### ❤️ Thank You
- auvred
- Brad Zacher
- Kirk Waiblinger
- Pete Gonzalez
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.20.0 (2024-01-29)
##### 🚀 Features
- **eslint-plugin:** \[member-ordering] allow easy reuse of the default ordering
##### 🩹 Fixes
- **eslint-plugin:** \[no-useless-template-literals] incorrect bigint autofix result
- **eslint-plugin:** \[prefer-nullish-coalescing] treat any/unknown as non-nullable
- **eslint-plugin:** \[no-useless-template-literals] report Infinity & NaN
- **eslint-plugin:** \[prefer-readonly] disable checking accessors
##### ❤️ Thank You
- Alex Parloti
- auvred
- James Browning
- StyleShit
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.19.1 (2024-01-22)
##### 🩹 Fixes
- **type-utils:** preventing isUnsafeAssignment infinite recursive calls
- **eslint-plugin:** \[no-unnecessary-condition] fix false positive for type variable
##### ❤️ Thank You
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.19.0 (2024-01-15)
##### 🚀 Features
- **eslint-plugin:** \[prefer-promise-reject-errors] add rule
- **eslint-plugin:** \[no-array-delete] add new rule
- **eslint-plugin:** \[no-useless-template-literals] add fix suggestions
##### 🩹 Fixes
- **eslint-plugin:** \[no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression
- **eslint-plugin:** \[no-unnecesary-type-assertion] treat unknown/any as nullable
##### ❤️ Thank You
- auvred
- Brad Zacher
- Josh Goldberg ✨
- Joshua Chen
- LJX
- Steven
- StyleShit
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.18.1 (2024-01-08)
##### 🩹 Fixes
- **eslint-plugin:** \[no-non-null-assertion] provide valid fix when member access is on next line
- **eslint-plugin:** \[no-unnecessary-condition] improve checking optional callee
- **eslint-plugin:** \[prefer-readonly] support modifiers of unions and intersections
- **eslint-plugin:** \[switch-exhaustiveness-check] fix new allowDefaultCaseForExhaustiveSwitch option
##### ❤️ Thank You
- auvred
- James
- Josh Goldberg ✨
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.18.0 (2024-01-06)
##### 🚀 Features
- **typescript-estree:** throw on invalid update expressions
- **eslint-plugin:** \[no-var-requires, no-require-imports] allow option
##### ❤️ Thank You
- auvred
- Joshua Chen
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
### [`v6.21.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6210-2024-02-05 )
[Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.20.0...v6.21.0 )
##### 🚀 Features
- export plugin metadata
- allow `parserOptions.project: false`
- **eslint-plugin:** add rule prefer-find
##### 🩹 Fixes
- **eslint-plugin:** \[no-unused-vars] don't report on types referenced in export assignment expression
- **eslint-plugin:** \[switch-exhaustiveness-check] better support for intersections, infinite types, non-union values
- **eslint-plugin:** \[consistent-type-imports] dont report on types used in export assignment expressions
- **eslint-plugin:** \[no-unnecessary-condition] handle left-hand optional with exactOptionalPropertyTypes option
- **eslint-plugin:** \[class-literal-property-style] allow getter when same key setter exists
- **eslint-plugin:** \[no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before `as` keyword
##### ❤️ Thank You
- auvred
- Brad Zacher
- Kirk Waiblinger
- Pete Gonzalez
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
</details>
<details>
<summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary>
### [`v7.0.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#701-2024-02-12 )
[Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v7.0.0...v7.0.1 )
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
### [`v7.0.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#700-2024-02-12 )
[Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.21.0...v7.0.0 )
##### 🚀 Features
- ⚠️ bump ESLint, NodeJS, and TS minimum version requirements
- add support for flat configs
##### ⚠️ Breaking Changes
- ⚠️ bump ESLint, NodeJS, and TS minimum version requirements
##### ❤️ Thank You
- Brad Zacher
- Kirk Waiblinger
- StyleShit
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.21.0 (2024-02-05)
##### 🚀 Features
- allow `parserOptions.project: false`
##### ❤️ Thank You
- auvred
- Brad Zacher
- Kirk Waiblinger
- Pete Gonzalez
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.20.0 (2024-01-29)
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.19.1 (2024-01-22)
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.19.0 (2024-01-15)
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.18.1 (2024-01-08)
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
#### 6.18.0 (2024-01-06)
This was a version bump only for parser to align it with other projects, there were no code changes.
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
### [`v6.21.0`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#6210-2024-02-05 )
[Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.20.0...v6.21.0 )
##### 🚀 Features
- allow `parserOptions.project: false`
##### ❤️ Thank You
- auvred
- Brad Zacher
- Kirk Waiblinger
- Pete Gonzalez
- YeonJuan
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning ) and [releases](https://main--typescript-eslint.netlify.app/users/releases ) on our website.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View repository job log [here](https://developer.mend.io/github/napi-rs/napi-rs ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
2024-02-13 12:31:38 +08:00
LongYinan
7d28d7aae4
chore(release): publish
...
- @napi-rs/cli@3.0.0-alpha.38
2024-02-13 01:12:40 +08:00
LongYinan
bec6bd67be
feat(cli): respect WASI_SDK_PATH env ( #1946 )
2024-02-13 01:12:08 +08:00
LongYinan
f60c465950
chore(release): publish
...
- @napi-rs/cli@3.0.0-alpha.37
2024-02-12 16:11:22 +08:00
LongYinan
da2f412d79
fix(cli): log more wasi load errors ( #1943 )
2024-02-08 21:54:34 +08:00
LongYinan
ff2ccc9f37
fix(cli): log more wasi load errors
2024-02-08 13:24:12 +00:00
LongYinan
0205fd976e
fix(cli): setup cxx env while using napi-cross ( #1942 )
2024-02-08 21:23:40 +08:00
LongYinan
b6adf8ae5c
Release independent packages
...
napi-derive@2.15.1
2024-02-08 20:41:49 +08:00
LongYinan
adbd34c0b9
fix(napi-derive): serde Number typing ( #1941 )
2024-02-08 18:20:46 +08:00
renovate[bot]
464abaefed
chore(deps): update dependency @taplo/cli to ^0.7.0 ( #1939 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-02-01 15:25:39 +00:00
LongYinan
5b66467e09
Release independent packages
...
- napi@2.15.1
2024-02-01 22:16:22 +08:00
LongYinan
f40747aa4c
fix(napi): in "Object::get", return null values wrapped in a "Some" ( #1934 )
...
Hi 👋🏻 , Alberto from @prisma here.
We are users of the `serde-json` feature in [23fdc5965b/Cargo.toml (L55-L60)https://github.com/prisma/prisma/issues/22294 ), we noticed that napi.rs treats `null` values in `Object` like `undefined` ones.
However, `null` and `undefined` are semantically different in JavaScript:
- `undefined` indicates that a value is not set
- `null` indicates that a value has been explicitly set
This PR, which we tested internally, fixes the user's issue on Prisma, and hopefully provides value to the `napi-rs` project as a whole.
## Scenario
Consider [this scenario](dcb8cb9817/query-engine/driver-adapters/src/napi/result.rs (L32-L33)https://github.com/napi-rs/napi-rs/blob/napi%402.12.4/crates/napi/src/bindgen_runtime/js_values/serde.rs ), we [can see](https://github.com/napi-rs/napi-rs/blob/napi%402.12.4/crates/napi/src/bindgen_runtime/js_values/serde.rs#L104-L108 ) that "JSON subobjects" (`Map<String, serde_json::Value>`) are populated only if the value returned by `JsObject::get` is not `None`.
This implies that, given `napi-rs`' [`Object::get` definition](https://github.com/napi-rs/napi-rs/blob/napi%402.12.4/crates/napi/src/bindgen_runtime/js_values/object.rs#L24-L44 ), `Object::get("key")` returns `None` both when the original object is
```js
{
// "key" is `undefined`
}
```
and when the object is
```js
{
"key": null
}
```
It just so happens that `prisma-engines` explicitly set a few `null` values explicitly for the features it offers, but these values are stripped away when we use the [napi-flavoured Prisma Query Engine](https://github.com/prisma/prisma-engines/tree/main/query-engine/query-engine-node-api ).
---
I am available for further comments, clarifications, and refactorings. Have a good day!
2024-02-01 22:13:54 +08:00
Alberto Schiabel
2c8d418cdf
Merge branch 'main' into fix/object-get-null
2024-02-01 09:41:04 +01:00
